[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21072: Brave new mark-defun (and a testing tool)
From: |
Marcin Borkowski |
Subject: |
bug#21072: Brave new mark-defun (and a testing tool) |
Date: |
Wed, 03 May 2017 17:20:56 +0200 |
User-agent: |
mu4e 0.9.19; emacs 26.0.50 |
On 2017-05-01, at 00:21, npostavs@users.sourceforge.net wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> This suggests that the first arg is not "evaluated by the macro itself
>> at compile time", but instead is passed unevaluated to `insert`, in
>> which case it can't be instrumented.
>
> Oh, I see, this patch works, although it surprised me a bit to start
> stepping immediately when doing the C-u C-M-x.
>
> --- i/test/lisp/emacs-lisp/lisp-tests.el
> +++ w/test/lisp/emacs-lisp/lisp-tests.el
> @@ -320,12 +320,10 @@ elisp-tests-with-temp-buffer
> of the form =!NAME= in CONTENTS are removed, and a for each one a
> variable called NAME is bound to the position of the word's
> start."
> - (declare (indent 1) (debug (form body)))
> + (declare (indent 1) (debug (def-form body)))
> (let* ((var-pos nil)
> (text (with-temp-buffer
> - (insert (cond ((symbolp contents)
> - (symbol-value contents))
> - (t contents)))
> + (insert (eval contents))
> (goto-char (point-min))
> (while (re-search-forward elisp-test-point-position-regex
> nil t)
> (push (list (intern (match-string-no-properties 1))
Hi Stefan and Noam,
I finally analyzed Noam's code, and the very same thing occurred to me:
that using `(eval contents)' would both be more reasonable (after all,
CONTENTS might be neither a symbol nor a string, but some expression!)
and at the same time consistent with Noam's rewording of the docstring.
Thanks!
I'm in a train now, and with limited access to the internet, so I'll get
back to this thread (and push the branch after clean-up - I guess I'll
have to delete the current branch first, right?) soon.
It's good that the Emacs manuals are available offline - I'll read about
arguments to `debug' now. ;-)
Best,
--
Marcin Borkowski
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/05/03
- bug#21072: Brave new mark-defun (and a testing tool),
Marcin Borkowski <=
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/05/09
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/05/12
- bug#21072: Brave new mark-defun (and a testing tool), npostavs, 2017/05/12
- bug#21072: Brave new mark-defun (and a testing tool), Marcin Borkowski, 2017/05/14
- bug#21072: Brave new mark-defun (and a testing tool), Glenn Morris, 2017/05/14
- bug#21072: Brave new mark-defun (and a testing tool), npostavs, 2017/05/16