Re: wget2 | Draft: *Integration of ngtcp2 and nghttp3 with wget2 (!527)

[Ander Juaristi (@juaristi)]

Merge request https://gitlab.com/gnuwget/wget2/-/merge_requests/527 was 
reviewed by Ander Juaristi

--
  
Ander Juaristi started a new discussion on libwget/quic.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527#note_1511087915

> +                             quic->local->size = sizeof(quic->local->addr);
> +                             len = (socklen_t) quic->local->size;
> +                             getsockname(sockfd, quic->local->addr, &len);

Check return value and close socket on error

--
  
Ander Juaristi started a new discussion on libwget/quic.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527#note_1511087920

> +     */
> +     // settings.log_printf = log_printf;
> +     settings.log_printf = NULL;

I would tell you to set this to `wget_debug_printf` (or its shorthand 
`debug_printf`), but will not work because the signatures of the functions 
won't match. Instead, I would set this to your own `log_printf` and then call 
`debug_printf` there.

--
  
Ander Juaristi started a new discussion on libwget/quic.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527#note_1511087925

> +     (void) user_data;
> +
> +     va_start(ap, fmt);

Why not call `wget_debug_printf`/`wget_debug_vprintf` here? (or its shorthand 
`debug_printf`)




-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/527
You're receiving this email because of your account on gitlab.com.