wget2 | [Question] Packaging wget2 (#565)

[Michal Ruprich (@mruprich)]

Michal Ruprich created an issue: https://gitlab.com/gnuwget/wget2/-/issues/565



Hi all,

I started preparing wget2 to package it and put it in Fedora and I would like 
to ask you a couple of questions, if you don't mind.

1. What is the purpose of wget_noinstall? While building in Fedora, I've hit a 
problem with hardcoded rpaths with this binary and basically had to delete it 
to get past it.

2. I've been hitting a lot of issues with the maint.mk file that is invoked 
during the 'make check' specifically when 'make check-local' is called. A lot 
of errors like these:

```
make  check-local
make[2]: Entering directory '/root/rpmbuild/BUILD/wget2-2.0.0'
maint.mk: GPL vN, N!=3
make[3]: *** [maint.mk:935: sc_GPL_version] Error 1
make[2]: *** [Makefile:2395: check-local] Error 2

------------------

make  check-local
make[2]: Entering directory '/root/rpmbuild/BUILD/wget2-2.0.0'
maint.mk: found useless "if"make[3]: *** [maint.mk:347: 
sc_avoid_if_before_free] Error 1
make[2]: *** [Makefile:2395: check-local] Error 2
make[2]: Leaving directory '/root/rpmbuild/BUILD/wget2-2.0.0'

----------------

make  check-local
make[2]: Entering directory '/root/rpmbuild/BUILD/wget2-2.0.0'
maint.mk: the above files do not call bindtextdomain
make[3]: *** [maint.mk:792: sc_bindtextdomain] Error 1
make[2]: *** [Makefile:2395: check-local] Error 2

-----------------

make  check-local
make[2]: Entering directory '/root/rpmbuild/BUILD/wget2-2.0.0'
maint.mk: don't cast alloca return value
make[3]: *** [maint.mk:367: sc_cast_of_alloca_return_value] Error 1
make[2]: *** [Makefile:2395: check-local] Error 2

-----------------

make  check-local
make[2]: Entering directory '/root/rpmbuild/BUILD/wget2-2.0.0'
maint.mk: don't cast free argument
make[3]: *** [maint.mk:358: sc_cast_of_argument_to_free] Error 1
make[2]: *** [Makefile:2395: check-local] Error 2

------------------

make  check-local
make[2]: Entering directory '/root/rpmbuild/BUILD/wget2-2.0.0'
maint.mk: don't cast x*alloc return value
make[3]: *** [maint.mk:362: sc_cast_of_x_alloc_return_value] Error 1
make[2]: *** [Makefile:2395: check-local] Error 2

------------------

make  check-local
make[2]: Entering directory '/root/rpmbuild/BUILD/wget2-2.0.0'
maint.mk: found use of "filesystem"; spell it "file system"
make[3]: *** [maint.mk:491: sc_file_system] Error 1
make[2]: *** [Makefile:2395: check-local] Error 2
...
```

The list goes on and the result does not say much about where is the issue 
found etc. So my question is, what is the purpose of this check? Seems like 
this is supposed to check syntax and other errors in the code that should 
probably be fixed already but won't let you build it if they are not? I had to 
disable this altogether to get past it.

Thanks for any info about this.

Regards,
Michal Ruprich

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/issues/565
You're receiving this email because of your account on gitlab.com.