wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Add --background support for Windows (!464)


From: Tim Rühsen
Subject: Re: wget2 | Add --background support for Windows (!464)
Date: Mon, 27 Jan 2020 09:38:34 +0000



Tim Rühsen started a new discussion on src/wget_main.h: 
https://gitlab.com/gnuwget/wget2/merge_requests/464#note_277207565

>  // I try to never leave freed pointers hanging around
>  #define xfree(a) do { if (a) { wget_free((void *)(a)); a=NULL; } } while (0)
>  
> +// Zero out a value.
> +#define xzero(x) memset (&(x), '\0', sizeof (x))

Please remove this and use memset explicitly. There is only one occurrence and 
xzero just hides the real code without giving benefit.

We could think about using such a shortcut as a static inline function in the 
future (if that makes sense).

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/464#note_277207565
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]