wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Add option --bind-interface (!462)


From: Tim Rühsen
Subject: Re: wget2 | Add option --bind-interface (!462)
Date: Tue, 10 Dec 2019 07:14:03 +0000



Tim Rühsen commented:


If you look at the CI again, there are three issues that has to be addressed:
- add yourself to AUTHORS (last line)
- check if `SO_BINDDEVICE` is defined before using it. there should also be a 
warning if --bind-interface is requested but `SO_BINDDEVICE` is not available.
- strlen() in setsockopt must be cast to `socklen_t`

Then we need the FSF copyright assignment from you to be able to accept your 
contribution. Please see
https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future

Best if you put me and Darshit on the CC (find our email addresses e.g. in `git 
log`).

Let me know if you have any questions.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/462#note_257961666
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]