wget-dev
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Added --convert-file-only handling (!456)

From: Tim Rühsen
Subject: Re: wget2 | Added --convert-file-only handling (!456)
Date: Wed, 06 Nov 2019 10:43:03 +0000 


Tim Rühsen commented on a discussion on tests/test-convert-file-only.c: 
https://gitlab.com/gnuwget/wget2/merge_requests/456#note_240743008

> +                             "Content-Type: text/html",
> +                     }
> +             },
> +             {       .name = "/subdir/page7",
> +                     .code = "200 Dontcare",
> +                     .body = "<html><head><title>Page 
> 7</title></head><body>Some Text</body></html>",
> +                     .headers = {
> +                             "Content-Type: text/html",
> +                     }
> +             },
> +
> +     };
> +
> +     const char *mainpagemangled =
> +             "<html><head><title>Main Page</title></head><body><p>A link to 
> a" \
> +             " <a href=\"//localhost:{{port}}/subpage.php.html\">second 
> page</a>." \

Ok thanks, I'm back on the road now :-)

So the `page6` link isn't converted to an absolute URL, even though it doesn't 
exist ? Well, this option seems to be such a special case, I hardly can imagine 
how it really works.

BTW, wget1.x creates a slightly different output (use `WGET_TEST_EXECUTABLE, 
"wget",` when calling `wget_test()`):
```
Unexpected content in index.php.html [-r -nH -E --convert-file-only]
  Expected 347 bytes:
<html><head><title>Main Page</title></head><body><p>A link to a <a 
href="//localhost:42565/subpage.php.html">second page</a>. <a 
href="//localhost:42565/thirdpage">third page</a>. <a 
href="http://localhost:42565/page4";>page4</a>. <a href="/page5.html">page5</a>. 
<a href="page6">page6</a>. <a 
href="/subdir/page7.html">page7</a>.</p></body></html>
  Got 365 bytes:
<html><head><title>Main Page</title></head><body><p>A link to a <a 
href="//localhost:42565/subpage.php">second page</a>. <a 
href="http://localhost:42565/thirdpage";>third page</a>. <a 
href="http://localhost:42565/page4";>page4</a>. <a href="/page5">page5</a>. <a 
href="http://localhost:42565/page6";>page6</a>. <a 
href="/subdir/page7.html">page7</a>.</p></body></html>
FAIL test-convert-file-only (exit status: 1)
```

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/456#note_240743008
You're receiving this email because of your account on gitlab.com.
reply via email to
[Prev in Thread] Current Thread [Next in Thread]