wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Added --convert-file-only handling (!456)


From: Tim Rühsen
Subject: Re: wget2 | Added --convert-file-only handling (!456)
Date: Tue, 05 Nov 2019 14:49:30 +0000



Tim Rühsen started a new discussion on src/wget.c: 
https://gitlab.com/gnuwget/wget2/merge_requests/456#note_240300813

> -                                     wget_buffer_reset(&buf); // reuse buffer
> -                                     while (*p2) {
> -                                             if (*p2++ == '/')
> -                                                     
> wget_buffer_memcat(&buf, "../", 3);
> -                                     }
> -                                     wget_buffer_strcat(&buf, dir);
> -
> -                                     wget_info_printf("  %.*s -> %s\n", 
> (int) url->len,  url->p, linkpath); // no translation
> -                                     wget_info_printf("       -> %s\n", 
> buf.data); // no translation
> -                             } else {
> -                                     // insert absolute URL
> -                                     wget_info_printf("  %.*s -> %s\n", 
> (int) url->len,  url->p, buf.data); // no translation
> -                             }
> +                             if(config.convert_links)
> +                                     convert_link_whole(filename, 
> conversion, url, &buf);
> +                             else if(config.convert_file_only)

You assume that either `config.convert_links` or `config.convert_file_only` is 
set. Please add code to disallow a combination of both options.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/456#note_240300813
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]