|
From: | Tim Rühsen |
Subject: | Re: [Wget-dev] wget2 | * tests/libtest.c: Create directories if needed when creating WGET_TEST_EXISTING_FILES (!440) |
Date: | Thu, 22 Aug 2019 12:48:37 +0000 |
Tim Rühsen commented on a discussion on tests/libtest.c: https://gitlab.com/gnuwget/wget2/merge_requests/440#note_206827790 > // create files > if (existing_files) { > for (it = 0; existing_files[it].name; it++) { > + const char *namecpy = > wget_strdup(existing_files[it].name); Ouch ! This is the type of (speed) optimization I sometimes do. And here you learn something: don't do that or make the param 'char *'. All because C doesn't have a 'string literal' (read-only memory region) type. Let me have a look if I can change mkdir_path itself. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnuwget/wget2/merge_requests/440#note_206827790 You're receiving this email because of your account on gitlab.com.
[Prev in Thread] | Current Thread | [Next in Thread] |