Re: [Wget-dev] wget2 | Add Last-Modified and Content-Type to CSV stats (!417)

[Darshit Shah]

Merge request https://gitlab.com/gnuwget/wget2/merge_requests/417 was reviewed 
by Darshit Shah

--
  
Darshit Shah started a new discussion on src/stats_site.c:

>               doc->size_downloaded, doc->size_decompressed, transfer_time,
> -             doc->initial_response_duration, doc->encoding, 
> doc->signature_status);
> +             doc->initial_response_duration, doc->encoding, 
> doc->signature_status, doc->time, doc->mime_type);

Atleast online, the indentation seems a little off here. I'll check it locally

--
  
Darshit Shah started a new discussion on src/stats_site.c:

>               doc->method = STATS_METHOD_POST;
>       }
> -

Don't remove this newline for no reason

--
  
Darshit Shah started a new discussion on src/stats_site.c:

>               signature_status; //!< 0=None 1=valid 2=invalid 3=bad 4=missing
>       char
> +             time[50],

Why does time need to be 50 chars?

--
  
Darshit Shah started a new discussion on src/stats_site.c:

> +     localtime_r(&attrib.st_mtime, &tm);
> +     stat("doc->iri->uri", &attrib);
> +     strftime(doc->time, 100, "%Y-%m-%d %H:%M:%S", &tm);

If time if only 50 chars, why is `strftime` allowed to write 100 chars!!

--
  
Darshit Shah started a new discussion on src/stats_site.c:

> +     struct tm tm;
> +
> +     time(&attrib.st_mtime);

I don't follow this. Why is the current time needed for the mtime of the file? 
It's not being modified at all!


-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/417
You're receiving this email because of your account on gitlab.com.