wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | Fix -p -nc behavior if document already exists (#


From: Kumar Mallikarjuna
Subject: Re: [Wget-dev] wget2 | Fix -p -nc behavior if document already exists (#209)
Date: Tue, 05 Mar 2019 14:55:16 +0000

In [wget.c (commit: 
cdb3600791f324b00b6655fb8eee9815d219e795)](https://gitlab.com/gnuwget/wget2/commit/cdb3600791f324b00b6655fb8eee9815d219e795#af78bb00d7679958da616bc53f20fa39bb038ff0),<br>
`if (oflag == O_TRUNC && !(config.recursive && config.directories))` (Line 
3156).<br>
When specifying "-p", config.recursive is set to 1 and 
config.directories.config is also 1, therefore when "-p" is set, the condition 
is not satisfied and therefore flag is not set to O_EXCL due to which a 
download starts even if the file already exists.
But after changing the said condition to
`if (oflag == O_TRUNC)`, the retrieval stops after robots.txt and index.html as 
they already exist but static files of index.html are not checked for. This 
happens because after<br>
`if (ctx->outfd == -1)
                        ret = -1;
` (Line 3329, 3330)<br>
"ret" is set to -1. Any ideas how to proceed further?

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/issues/209#note_147454045
You're receiving this email because of your account on gitlab.com.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]