Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383)

[DalmeGNU]

Sorry but this makes no sense to me: After some tries (all still with leaks) 
I've replaced parse_included_directories() as the function that parses 
--include-directories in options.c for parse_stringlist() and after make & make 
check-valgrind it still leaks, but other tests like e.g. --filter-mime-types 
which also uses parse_stringlist() don't do.

```
==1575== HEAP SUMMARY:
==1575==     in use at exit: 122 bytes in 6 blocks
==1575==   total heap usage: 1,701 allocs, 1,695 frees, 1,391,609 bytes 
allocated
==1575== 
==1575== 9 bytes in 2 blocks are still reachable in loss record 1 of 4
==1575==    at 0x4C28C20: malloc (vg_replace_malloc.c:296)
==1575==    by 0x4E690F9: wget_malloc (xalloc.c:98)
==1575==    by 0x4E5BB96: wget_strmemdup (mem.c:88)
==1575==    by 0x4178F2: parse_stringlist_expand (options.c:402)
==1575==    by 0x4179BF: parse_stringlist (options.c:421)
==1575==    by 0x4198A4: set_long_option (options.c:2284)
==1575==    by 0x41A338: parse_command_line (options.c:2537)
==1575==    by 0x41AE26: init (options.c:2805)
==1575==    by 0x40FD9D: main (wget.c:1231)
==1575== 
==1575== 9 bytes in 2 blocks are still reachable in loss record 2 of 4
==1575==    at 0x4C28C20: malloc (vg_replace_malloc.c:296)
==1575==    by 0x4E690F9: wget_malloc (xalloc.c:98)
==1575==    by 0x4E5BB96: wget_strmemdup (mem.c:88)
==1575==    by 0x4178F2: parse_stringlist_expand (options.c:402)
==1575==    by 0x4179BF: parse_stringlist (options.c:421)
==1575==    by 0x4198A4: set_long_option (options.c:2284)
==1575==    by 0x41A338: parse_command_line (options.c:2537)
==1575==    by 0x41B089: init (options.c:2867)
==1575==    by 0x40FD9D: main (wget.c:1231)
==1575== 
==1575== 40 bytes in 1 blocks are still reachable in loss record 3 of 4
==1575==    at 0x4C2AD10: calloc (vg_replace_malloc.c:623)
==1575==    by 0x4E69142: wget_calloc (xalloc.c:119)
==1575==    by 0x4E67C0E: wget_vector_create (vector.c:70)
==1575==    by 0x41785C: parse_stringlist_expand (options.c:393)
==1575==    by 0x4179BF: parse_stringlist (options.c:421)
==1575==    by 0x4198A4: set_long_option (options.c:2284)
==1575==    by 0x41A338: parse_command_line (options.c:2537)
==1575==    by 0x41AE26: init (options.c:2805)
==1575==    by 0x40FD9D: main (wget.c:1231)
==1575== 
==1575== 64 bytes in 1 blocks are still reachable in loss record 4 of 4
==1575==    at 0x4C28C20: malloc (vg_replace_malloc.c:296)
==1575==    by 0x4E690F9: wget_malloc (xalloc.c:98)
==1575==    by 0x4E67C23: wget_vector_create (vector.c:72)
==1575==    by 0x41785C: parse_stringlist_expand (options.c:393)
==1575==    by 0x4179BF: parse_stringlist (options.c:421)
==1575==    by 0x4198A4: set_long_option (options.c:2284)
==1575==    by 0x41A338: parse_command_line (options.c:2537)
==1575==    by 0x41AE26: init (options.c:2805)
==1575==    by 0x40FD9D: main (wget.c:1231)
==1575== 
==1575== LEAK SUMMARY:
==1575==    definitely lost: 0 bytes in 0 blocks
==1575==    indirectly lost: 0 bytes in 0 blocks
==1575==      possibly lost: 0 bytes in 0 blocks
==1575==    still reachable: 122 bytes in 6 blocks
==1575==         suppressed: 0 bytes in 0 blocks
```

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/383#note_96518120
You're receiving this email because of your account on gitlab.com.