wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383)


From: Tim Rühsen
Subject: Re: [Wget-dev] wget2 | WIP: Implementation of -I/-X options (!383)
Date: Thu, 23 Aug 2018 08:57:43 +0000

I just pushed -f due to a trailing space that I fixed in some older commit. 
`make check` failed because of that.

Please use wget_aprintf() to create the full_paths, e.g.
```
const char *full_path1 = wget_aprintf("localhost%s", urls[0].name);
```

Please fix the memory leak(s) (`make check-valgrind`):
```
==12895== 12 bytes in 2 blocks are still reachable in loss record 1 of 4
==12895==    at 0x48357BF: malloc (vg_replace_malloc.c:299)
==12895==    by 0x4879ADC: wget_malloc (xalloc.c:98)
==12895==    by 0x486C479: wget_strmemdup (mem.c:88)
==12895==    by 0x1275B2: parse_stringlist_expand (options.c:402)
==12895==    by 0x127801: parse_included_directories (options.c:449)
==12895==    by 0x129769: set_long_option (options.c:2283)
==12895==    by 0x12A276: parse_command_line (options.c:2536)
==12895==    by 0x12ADB0: init (options.c:2804)
==12895==    by 0x11F394: main (wget.c:1231)
==12895== 
==12895== 12 bytes in 2 blocks are still reachable in loss record 2 of 4
==12895==    at 0x48357BF: malloc (vg_replace_malloc.c:299)
==12895==    by 0x4879ADC: wget_malloc (xalloc.c:98)
==12895==    by 0x486C479: wget_strmemdup (mem.c:88)
==12895==    by 0x1275B2: parse_stringlist_expand (options.c:402)
==12895==    by 0x127801: parse_included_directories (options.c:449)
==12895==    by 0x129769: set_long_option (options.c:2283)
==12895==    by 0x12A276: parse_command_line (options.c:2536)
==12895==    by 0x12B021: init (options.c:2866)
==12895==    by 0x11F394: main (wget.c:1231)
==12895== 
==12895== 40 bytes in 1 blocks are still reachable in loss record 3 of 4
==12895==    at 0x48377D5: calloc (vg_replace_malloc.c:711)
==12895==    by 0x4879B25: wget_calloc (xalloc.c:119)
==12895==    by 0x48785E4: wget_vector_create (vector.c:70)
==12895==    by 0x12751E: parse_stringlist_expand (options.c:393)
==12895==    by 0x127801: parse_included_directories (options.c:449)
==12895==    by 0x129769: set_long_option (options.c:2283)
==12895==    by 0x12A276: parse_command_line (options.c:2536)
==12895==    by 0x12ADB0: init (options.c:2804)
==12895==    by 0x11F394: main (wget.c:1231)
```

Back to some old comments above...
"As I see testing the same as before but using wget1.x instead of wget2 it 
works without the "-nH", so I understand that we should compare -X / -I with a 
directory which is the URL string but starting at the first "/" coincidence 
after the http(s)://. Is that what we have to do?" YES

Does Wget1.x makes a difference with -nH when using -I/-X ? Wget2 should behave 
the same.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/383#note_96370958
You're receiving this email because of your account on gitlab.com.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]