wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | Documenting 'static inline' functions from wget.h


From: Tim Rühsen
Subject: Re: [Wget-dev] wget2 | Documenting 'static inline' functions from wget.h (#396)
Date: Tue, 21 Aug 2018 08:24:03 +0000

Type-checking is a good argument. 'modern' isn't an argument at all because it 
doesn't have a defined meaning.

BTW, 'inline' is covered by gnulib (m4/inline.m4). It is a #define to either 
'inline', '__inline', '__inline or empty. `HAVE_INLINE` is defined only if 
inlining *is* effective. Just tested it, with -O inlining is effective, else it 
isn't (gcc 8.2.0).

Back to the documentation issue. I see two options, either work-around it or 
getting it fixed in upstream doxygen. The work-around would be to move both 
functions into base64.c, removing the `static inline`. As you said (and I 
agree), there is no remarkable speed loss here.

At the same time we can contact the doxygen ML to ask for the needed 
improvement. Though I never got an answer when asking something there. @darnir, 
do you have time to talk with them ?

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/issues/396#note_95774506
You're receiving this email because of your account on gitlab.com.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]