wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | Fix progress display (issue #339) (!391)


From: Darshit Shah
Subject: Re: [Wget-dev] wget2 | Fix progress display (issue #339) (!391)
Date: Fri, 17 Aug 2018 08:44:27 +0000

Darshit Shah commented on a discussion on libwget/bar.c:

>       _bar_slot_t *slotp = &bar->slots[slot];
>  
>       xfree(slotp->filename);
> -     slotp->filename = wget_strdup(filename);
> +     if (++slotp->numfiles == 1) {
> +         slotp->filename = wget_strdup(filename);
> +         slotp->bytes_downloaded = 0;
> +     } else {
> +         char tag[128];

Won't `snprintf()` truncate to fit the size? The buffer is 20 chars since that 
is the amount of screen space provided for displaying the filename.

The rest is always truncated.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/391#note_95081385
You're receiving this email because of your account on gitlab.com.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]