Re: [Wget-dev] scripts under /benchmarks

[G_Gold]

Thank you Tim, Darshit. 

In benchmark.sh , the line:

WGET2="$SCRIPT_DIR/../src/wget2_noinstall 

might be referring to a directory that has been removed ever since ?

Thank you. 



On Tue,Jul 31 04:45:PM, Darshit Shah wrote:
> Hi,
> 
> These scripts were written last year in order to benchmark the network
> performance of Wget2 relative to the other major tools, Wget and cURL.
> 
> They're meant to be one shot with no arguments passed.
> 
> Since only a couple of us devs have ever used these scripts, they have some
> implicit assumptions. Tim already clarified how the paths are to be
> interpreted.
> 
> These scripts could definitely be cleaned up / expanded and any effort in that
> direction will be very appreciated! In case you're interested in doing so, I
> would recommend you start by cleaning up the scripts as best as you can
> (Shellcheck is an amazing tool for this).
> 
> Some ideas I have for expanding these scripts:
> 
> 1. Allow passing --benchmark-path as an argument which points to a directory
>    containing all containing all the sources (Wget, cURL, etc.)
> 2. Expand the scripts to cover some other popular tools (Aria2, axel, etc.)
> 3. As Tim mentioned, testing a recursive download (over HTTP/1.1 and HTTP/2)
> 
> Any other ideas that you may have for performance metrics when comparing such
> tools would also be welcome.
> 
> * G_Gold <address@hidden> [180731 10:38]:
> > Greetings list. 
> > 
> > I'd like to help and expand the scripts under /benchmarks, can
> > any of the members please help shed a bit more light on usage, or
> > any information that can help ?
> > 
> > When I call the script without arguments (should I be calling it with 
> > arguments? I'm not certain), it exits with:
> > 
> > address@hidden:~/wget2/benchmarks$ ./benchmark.sh
> > benchmark.sh: line 34: /home/guy/wget2/benchmarks/../../wget/src/wget: No 
> > such file or directory
> > 
> > it seems the relative paths are inaccurate (?)
> > 
> > Thank you. 
> > 
> > 
> > -- 
> > Guy Gold
> > 
> > 
> 
> -- 
> Thanking You,
> Darshit Shah
> PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6



-- 
Guy Gold