Re: "sed --debug" feature

[Jim Meyering]

On Thu, Oct 18, 2018 at 12:29 AM Assaf Gordon <address@hidden> wrote:
> Attached is the latest version of the "--debug" feature.
>
> The size increase is:
>
>     text    data     bss     dec     hex filename
>    99764    2796    2424  104984   19a18 sed-no-debug
>   106415    2852    2424  111691   1b44b sed-debug

Nice work. IMHO, this size increase (7% text) is justified.

NEWS suggestion: instead of this,

+  new --debug option prints the input sed script in canonical form
+  and annotates program execution.

use active voice:

   New option, --debug: print the input sed script in canonical form
   and annotate program execution.

--------------
Comment typos:

  s/tralsnation/translation/:
+      /* multibyte tralsnation */
+      /* unibyte tralsnation */

  s/ than/, then/ in "handled during compilation than discarded"

--------------
Formatting (please filter all new code through a formatter like GNU indent).

This:
  putchar (addr?'I':'i');
should be like this:
  putchar (addr ? 'I' : 'i');

Similarly for e.g., "for (i=0; i<256; ++i)".