Re: 'make clean' removes *.po with unintended consequences

[Jim Meyering]

On Mon, Aug 22, 2016 at 4:51 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
>
> On Aug 20, 2016, at 23:17, Jim Meyering <address@hidden> wrote:
>>
>> On Sat, Aug 20, 2016 at 7:33 PM, Assaf Gordon <address@hidden> wrote:
>>> I suspect commit 5b44cd0 ( "build: fix sed.1 dependency; work with latest 
>>> automake" ) had unintended consequences due to this:
>> [...]
>> The attached patch fixes it by removing the .deps directories only
>> while running distclean rules:
>> <distclean-check.diff>
>
> With the above patch, "make clean" works, but "make distclean" (in the source 
> directory does not).
> It also seems "make distcheck" does not for me (only tested on one Ubuntu 
> 14.04 machine).
> Lastly, there is a new warning when building with "make".
>
> regards,
>  - assaf
>
> ====
>
> $ make
> Makefile:6528: warning: overriding commands for target `distclean-local'
> Makefile:6513: warning: ignoring old commands for target `distclean-local'
>
> =====
>
> $ make distcheck
> [... configre + make + make check - succeed ... then ...]
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> make[2]: Leaving directory `/tmp/a/sed/sed-4.2.2.146-5cb09/_build'
> Making distclean in gnulib-tests
> make[2]: Entering directory 
> `/tmp/a/sed/sed-4.2.2.146-5cb09/_build/gnulib-tests'
> Makefile:2593: .deps/binary-io.Po: No such file or directory
> Makefile:2594: .deps/close.Po: No such file or directory
> Makefile:2595: .deps/closedir.Po: No such file or directory
> Makefile:2596: .deps/dup2.Po: No such file or directory
> Makefile:2597: .deps/fd-hook.Po: No such file or directory
> Makefile:2598: .deps/fdopen.Po: No such file or directory
> [...]
> Makefile:2718: .deps/test-xalloc-die.Po: No such file or directory
> Makefile:2719: .deps/unsetenv.Po: No such file or directory
> make[2]: *** No rule to make target `.deps/unsetenv.Po'.  Stop.
> make[2]: Leaving directory 
> `/tmp/a/sed/sed-4.2.2.146-5cb09/_build/gnulib-tests'
> make[1]: *** [distclean-recursive] Error 1
> make[1]: Leaving directory `/tmp/a/sed/sed-4.2.2.146-5cb09/_build'
> make: *** [distcheck] Error 1

Thanks for checking.
I haven't yet figured out why my tests showed no such failure, but
have written a more minimal patch: it removes only the two offending
.Po files:

distclean-check.diff
Description: Text document