[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
patch for 0.6.0.20070501-2:frontpage_controller
From: |
boud |
Subject: |
patch for 0.6.0.20070501-2:frontpage_controller |
Date: |
Wed, 2 May 2007 23:51:37 +0200 (CEST) |
hi samizdat-devel,
i see that the restructuring has been quite deep :) but that from a
naive user point of view, nothing much obvious has changed (which is
good), apart from the missing choice of changing languages. i've only
had a quick look so far, though.
Ah yes, my subjective impression agrees with the benchmarks: frontpage
reloading does seem to be faster now.
(1) COMMENT:
After updating with
aptitude update && aptitude upgrade
adding the template section to defaults.yaml as recommended, i got in my
browser:
Forbidden
You don't have permission to access / on this server.
So i read
NEWS.Debian.gz
and updated my apache config + database - relatively straightforward.
This got things looking reasonably normal.
i don't know whether the debian standard expects this sort of update
caveat to be given as a warning to the sysadmin running aptitude or
whether the sysadmin is expected to read obvious files in
/usr/share/doc/<packet>/ when a problem occurs.
(2) PATCH for frontpage_controller:
BUG: language_list was missing :(((, and language_list gave an old style
URL member.rb?set_lang= which fails
FIX:
* add language_list
* change from old style URL to new style URL
pozdr
boud
PATCH:
--- 0.6.0.20070501-2/lib/samizdat/controllers/frontpage_controller.rb
2007-04-22 16:13:47.000000000 +0200
+++ /usr/lib/ruby/1.8/samizdat/controllers/frontpage_controller.rb
2007-05-02 23:29:51.138834760 +0200
@@ -101,6 +101,7 @@
header and header =~ /[^\s]/
page += %{<div id="front-footer">#{footer}</div>\n} if
footer and footer =~ /[^\s]/
+ page = %{<div id="languages">#{language_list}</div>} + page # 20070502
end
# update cache
@@ -239,7 +240,7 @@
name += _(' (default language)') if
lang == config['locale']['languages'][0]
name = %{<strong>#{name}</strong>} if lang == old_language
- list += %{<a href="member.rb?set_lang=#{lang}">#{name}</a>\n}
+ list += %{<a href="member/set?lang=#{lang}">#{name}</a>\n} # 20070502
end
%{<div id="languages">#{list}</div>}
end
- patch for 0.6.0.20070501-2:frontpage_controller,
boud <=
- Re: patch for 0.6.0.20070501-2:frontpage_controller, Dmitry Borodaenko, 2007/05/05
- Re: patch for 0.6.0.20070501-2:frontpage_controller, boud, 2007/05/05
- Re: patch for 0.6.0.20070501-2:frontpage_controller, Dmitry Borodaenko, 2007/05/06
- Re: patch for 0.6.0.20070501-2:frontpage_controller, boud, 2007/05/06
- Re: patch for 0.6.0.20070501-2:frontpage_controller, Dmitry Borodaenko, 2007/05/08
- Re: patch for 0.6.0.20070501-2:frontpage_controller, Dmitry Borodaenko, 2007/05/09
- Re: caching deadlock solved, boud, 2007/05/10