qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b67de9: docs: Add caveats for Windows as the

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] b67de9: docs: Add caveats for Windows as the build platform
Date: Mon, 25 Jul 2022 05:50:06 -0700 
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: b67de91e0d4cae883a038f31b2207a1aaef5e51c
      
https://github.com/qemu/qemu/commit/b67de91e0d4cae883a038f31b2207a1aaef5e51c
  Author: Bin Meng <bin.meng@windriver.com>
  Date:   2022-07-22 (Fri, 22 Jul 2022)

  Changed paths:
    M docs/about/build-platforms.rst

  Log Message:
  -----------
  docs: Add caveats for Windows as the build platform

Commit cf60ccc3306c ("cutils: Introduce bundle mechanism") introduced
a Python script to populate a bundle directory using os.symlink() to
point to the binaries in the pc-bios directory of the source tree.
Commit 882084a04ae9 ("datadir: Use bundle mechanism") removed previous
logic in pc-bios/meson.build to create a link/copy of pc-bios binaries
in the build tree so os.symlink() is the way to go.

However os.symlink() may fail [1] on Windows if an unprivileged Windows
user started the QEMU build process, which results in QEMU executables
generated in the build tree not able to load the default BIOS/firmware
images due to symbolic links not present in the bundle directory.

This commits updates the documentation by adding such caveats for users
who want to build QEMU on the Windows platform.

[1] https://docs.python.org/3/library/os.html#os.symlink

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20220719135014.764981-1-bmeng.cn@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: d12dd9c7ee0ecab96efc21a263772fef2fff3ac6
      
https://github.com/qemu/qemu/commit/d12dd9c7ee0ecab96efc21a263772fef2fff3ac6
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-22 (Fri, 22 Jul 2022)

  Changed paths:
    M accel/kvm/kvm-all.c

  Log Message:
  -----------
  accel/kvm: Avoid Coverity warning in query_stats()

Coverity complains that there is a codepath in the query_stats()
function where it can leak the memory pointed to by stats_list.  This
can only happen if the caller passes something other than
STATS_TARGET_VM or STATS_TARGET_VCPU as the 'target', which no
callsite does.  Enforce this assumption using g_assert_not_reached(),
so that if we have a future bug we hit the assert rather than
silently leaking memory.

Resolves: Coverity CID 1490140
Fixes: cc01a3f4cadd91e6 ("kvm: Support for querying fd-based stats")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220719134853.327059-1-peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: d5b50236915be6f48e9ade9152273f0e902c63be
      
https://github.com/qemu/qemu/commit/d5b50236915be6f48e9ade9152273f0e902c63be
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2022-07-22 (Fri, 22 Jul 2022)

  Changed paths:
    M scripts/oss-fuzz/build.sh

  Log Message:
  -----------
  oss-fuzz: remove binaries from qemu-bundle tree

oss-fuzz is finding possible fuzzing targets even under qemu-bundle/.../bin, 
but they
cannot be used because the required shared libraries are missing.  Since the
fuzzing targets are already placed manually in $OUT, the bindir and libexecdir
subtrees are not needed; remove them.

Cc: Alexander Bulekov <alxndr@bu.edu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 7906f11e62c39cdbf8edc274cb311a420d675371
      
https://github.com/qemu/qemu/commit/7906f11e62c39cdbf8edc274cb311a420d675371
  Author: Alexander Bulekov <alxndr@bu.edu>
  Date:   2022-07-22 (Fri, 22 Jul 2022)

  Changed paths:
    M scripts/oss-fuzz/build.sh

  Log Message:
  -----------
  oss-fuzz: ensure base_copy is a generic-fuzzer

Depending on how the target list is sorted in by qemu, the first target
(used as the base copy of the fuzzer, to which all others are linked)
might not be a generic-fuzzer. Since we are trying to only use
generic-fuzz, on oss-fuzz, fix that, to ensure the base copy is a
generic-fuzzer.

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20220720180946.2264253-1-alxndr@bu.edu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 6b23a6791685ac1bf071c0ebb35004e427c1806d
      
https://github.com/qemu/qemu/commit/6b23a6791685ac1bf071c0ebb35004e427c1806d
  Author: Jason A. Donenfeld <Jason@zx2c4.com>
  Date:   2022-07-22 (Fri, 22 Jul 2022)

  Changed paths:
    M hw/nios2/boot.c

  Log Message:
  -----------
  hw/nios2: virt: pass random seed to fdt

If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to
initialize early. Set this using the usual guest random number
generation function. This FDT node is part of the DT specification.

Cc: Chris Wulff <crwulff@gmail.com>
Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220719120113.118034-1-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 5e19cc68fb42c6ecabe5cf37012c887d25ffd144
      
https://github.com/qemu/qemu/commit/5e19cc68fb42c6ecabe5cf37012c887d25ffd144
  Author: Jason A. Donenfeld <Jason@zx2c4.com>
  Date:   2022-07-22 (Fri, 22 Jul 2022)

  Changed paths:
    M hw/mips/boston.c

  Log Message:
  -----------
  hw/mips: boston: pass random seed to fdt

If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to
initialize early. Set this using the usual guest random number
generation function. This FDT node is part of the DT specification.

I'd do the same for other MIPS platforms but boston is the only one that
seems to use FDT.

Cc: Paul Burton <paulburton@kernel.org>
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220719120843.134392-1-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: c287941a4dd5570e4221b0a58590f7231f896e51
      
https://github.com/qemu/qemu/commit/c287941a4dd5570e4221b0a58590f7231f896e51
  Author: Jason A. Donenfeld <Jason@zx2c4.com>
  Date:   2022-07-22 (Fri, 22 Jul 2022)

  Changed paths:
    M hw/rx/rx-gdbsim.c

  Log Message:
  -----------
  hw/rx: pass random seed to fdt

If the FDT contains /chosen/rng-seed, then the Linux RNG will use it to
initialize early. Set this using the usual guest random number
generation function. This FDT node is part of the DT specification.

Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220719122033.135902-1-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 67f7e426e53833a5db75b0d813e8d537b8a75bd2
      
https://github.com/qemu/qemu/commit/67f7e426e53833a5db75b0d813e8d537b8a75bd2
  Author: Jason A. Donenfeld <Jason@zx2c4.com>
  Date:   2022-07-22 (Fri, 22 Jul 2022)

  Changed paths:
    M hw/i386/microvm.c
    M hw/i386/pc.c
    M hw/i386/pc_piix.c
    M hw/i386/pc_q35.c
    M hw/i386/x86.c
    M include/hw/i386/pc.h
    M include/hw/i386/x86.h
    M include/standard-headers/asm-x86/bootparam.h

  Log Message:
  -----------
  hw/i386: pass RNG seed via setup_data entry

Tiny machines optimized for fast boot time generally don't use EFI,
which means a random seed has to be supplied some other way. For this
purpose, Linux (≥5.20) supports passing a seed in the setup_data table
with SETUP_RNG_SEED, specially intended for hypervisors, kexec, and
specialized bootloaders. The linked commit shows the upstream kernel
implementation.

At Paolo's request, we don't pass these to versioned machine types ≤7.0.

Link: https://git.kernel.org/tip/tip/c/68b8e9713c8
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Eduardo Habkost <eduardo@habkost.net>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-Id: <20220721125636.446842-1-Jason@zx2c4.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 616a6459d878999b37c7cfbf1ed8d4ca84b3751f
      
https://github.com/qemu/qemu/commit/616a6459d878999b37c7cfbf1ed8d4ca84b3751f
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-07-25 (Mon, 25 Jul 2022)

  Changed paths:
    M accel/kvm/kvm-all.c
    M docs/about/build-platforms.rst
    M hw/i386/microvm.c
    M hw/i386/pc.c
    M hw/i386/pc_piix.c
    M hw/i386/pc_q35.c
    M hw/i386/x86.c
    M hw/mips/boston.c
    M hw/nios2/boot.c
    M hw/rx/rx-gdbsim.c
    M include/hw/i386/pc.h
    M include/hw/i386/x86.h
    M include/standard-headers/asm-x86/bootparam.h
    M scripts/oss-fuzz/build.sh

  Log Message:
  -----------
  Merge tag 'for-upstream2' of https://gitlab.com/bonzini/qemu into staging

* Bug fixes
* Pass random seed to x86 and other FDT platforms

# gpg: Signature made Fri 22 Jul 2022 18:26:45 BST
# gpg:                using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg:                issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [full]
# gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>" [full]
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* tag 'for-upstream2' of https://gitlab.com/bonzini/qemu:
  hw/i386: pass RNG seed via setup_data entry
  hw/rx: pass random seed to fdt
  hw/mips: boston: pass random seed to fdt
  hw/nios2: virt: pass random seed to fdt
  oss-fuzz: ensure base_copy is a generic-fuzzer
  oss-fuzz: remove binaries from qemu-bundle tree
  accel/kvm: Avoid Coverity warning in query_stats()
  docs: Add caveats for Windows as the build platform

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/7ceb28328f42...616a6459d878
reply via email to
[Prev in Thread] Current Thread [Next in Thread]