qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] decbc8: s390x: fix flat file load on 32 bit s


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] decbc8: s390x: fix flat file load on 32 bit systems
Date: Mon, 25 Nov 2013 11:30:06 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: decbc880289526d94495bcbe6e1ba2a11b92e7a8
      
https://github.com/qemu/qemu/commit/decbc880289526d94495bcbe6e1ba2a11b92e7a8
  Author: Michael S. Tsirkin <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M hw/s390x/ipl.c

  Log Message:
  -----------
  s390x: fix flat file load on 32 bit systems

pc-bios/s390-zipl.rom is a flat image so it's expected that
loading it as elf will fail.
It should fall back on loading a flat file, but doesn't
on 32 bit systems, instead it fails printing:
    qemu: hardware error: could not load bootloader 's390-zipl.rom'

The result is boot failure.

The reason is that a 64 bit unsigned interger which is set
to -1 on error is compared to -1UL which on a 32 bit system
with gcc is a 32 bit unsigned interger.
Since both are unsigned, no sign extension takes place and
comparison evaluates to non-equal.

There's no reason to do clever tricks: all functions
we call actually return int so just use int.
And then we can use == -1 everywhere, consistently.

Reviewed-by: Alexander Graf <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 5c397242d5d53c1adecce31817bb439383cf8228
      
https://github.com/qemu/qemu/commit/5c397242d5d53c1adecce31817bb439383cf8228
  Author: Bandan Das <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M hw/pci/pci.c

  Log Message:
  -----------
  pci: unregister vmstate_pcibus on unplug

PCIBus registers a vmstate during init. Unregister it upon
removal/unplug.

Signed-off-by: Bandan Das <address@hidden>
Cc: address@hidden
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 8b9c3b897c682cd9739c6aef73b3220c7204c243
      
https://github.com/qemu/qemu/commit/8b9c3b897c682cd9739c6aef73b3220c7204c243
  Author: Michael S. Tsirkin <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  acpi-build: fix build on glib < 2.22

g_string_vprintf was only introduced in 2.24 so switch to vsnprintf
instead.  A bit uglier but name size is fixed at 4 bytes here so it's
easy.

Reviewed-by: Paolo Bonzini <address@hidden>
Reported-by: Richard Henderson <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: fd8f5e37557596e14a859d8edf3dc24523bd4400
      
https://github.com/qemu/qemu/commit/fd8f5e37557596e14a859d8edf3dc24523bd4400
  Author: Michael S. Tsirkin <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M hw/i386/acpi-build.c
    M hw/i386/bios-linker-loader.c

  Log Message:
  -----------
  acpi-build: fix build on glib < 2.14

g_array_get_element_size was only added in glib 2.14,
there's no way to find element size in with an older glib.

Fortunately we only use a single table (linker) where element size > 1.
Switch element size to 1 everywhere, then we can just look at len field
to get table size in bytes.

Add an assert to make sure we catch any violations of this rule.

Reviewed-by: Paolo Bonzini <address@hidden>
Reported-by: Richard Henderson <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 90d131fb6504ed12a37dc8433375cc683c30e9da
      
https://github.com/qemu/qemu/commit/90d131fb6504ed12a37dc8433375cc683c30e9da
  Author: Michael S. Tsirkin <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M hw/net/e1000.c
    M hw/net/rtl8139.c

  Log Message:
  -----------
  Revert "e1000/rtl8139: update HMP NIC when every bit is written"

This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757.
Digging into hardware specs shows this does not
actually make QEMU behave more like hardware:

There are valid arguments backed by the spec to indicate why the version
of e1000 prior to cd5be582 was more correct: the high byte actually
includes a valid bit, this is why all guests write it last.

For rtl8139 there's actually a separate undocumented valid bit, but we
don't implement it yet.

To summarize all the drivers we know about behave in one way
that allows us to make an assumption about write order and avoid
spurious, incorrect mac address updates to the monitor.

Let's stick to the tried heuristic for 1.7 and
possibly revisit for 1.8.

Reported-by: Vlad Yasevich <address@hidden>
Reviewed-by: Vlad Yasevich <address@hidden>
Cc: Amos Kong <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: da87dd7bd70f71ceaf9ff40d7cdb8394a7dc4bf5
      
https://github.com/qemu/qemu/commit/da87dd7bd70f71ceaf9ff40d7cdb8394a7dc4bf5
  Author: Mark Cave-Ayland <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M Makefile
    M hw/display/tcx.c
    M hw/sparc/sun4m.c
    A pc-bios/QEMU,tcx.bin
    M pc-bios/README

  Log Message:
  -----------
  sun4m: Add FCode ROM for TCX framebuffer

Upstream OpenBIOS now implements SBus probing in order to determine the
contents of a physical bus slot, which is required to allow OpenBIOS to
identify the framebuffer without help from the fw_cfg interface.

SBus probing works by detecting the presence of an FCode program
(effectively tokenised Forth) at the base address of each slot, and if
present executes it so that it creates its own device node in the
OpenBIOS device tree.

The FCode ROM is generated as part of the OpenBIOS build and should
generally be updated at the same time.

Signed-off-by: Mark Cave-Ayland <address@hidden>
CC: Blue Swirl <address@hidden>
CC: Bob Breuer <address@hidden>
CC: Artyom Tarasenko <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 45d285abd7028ac72418c1a22f9298bb898fbfb8
      
https://github.com/qemu/qemu/commit/45d285abd7028ac72418c1a22f9298bb898fbfb8
  Author: Peter Maydell <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0

Our rules.mak adds '-rR' to MAKEFLAGS to indicate that we will be
explicitly specifying everything and not relying on any default
variables or rules. However we were accidentally relying on the
default ARFLAGS ("rv"). This went unnoticed because of a bug in
GNU Make 3.82 and earlier which meant that adding -rR to MAKEFLAGS
only affected submakes, not the currently running instance.
Explicitly set ARFLAGS in config-host.mak, in the same way we
handle CFLAGS and LDFLAGS; this will allow us to work with
Make 4.0.

Thanks to Paul Smith for analyzing this bug for us.

Cc: address@hidden
Reported-by: Ken Moffat <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 7839ff593be03a7de3c6760e0b50c565ea751d36
      
https://github.com/qemu/qemu/commit/7839ff593be03a7de3c6760e0b50c565ea751d36
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M hw/i386/pc_piix.c
    M hw/i386/pc_q35.c
    M hw/misc/pvpanic.c
    M include/hw/i386/pc.h

  Log Message:
  -----------
  pc: get rid of builtin pvpanic for "-M pc-1.5"

This causes two slight backwards-incompatibilities between "-M pc-1.5"
and 1.5's "-M pc":

(1) a fw_cfg file is removed with this patch.  This is only a problem
if migration stops the virtual machine exactly during fw_cfg enumeration.

(2) after migration, a VM created without an explicit "-device pvpanic"
will stop reporting panics to management.

The first problem only occurs if migration is done at a very, very
early point (and I'm not sure it can happen in practice for reasonable-size
VMs, since it will likely take more time to send the RAM to destination,
than it will take for BIOS to scan fw_cfg).

The second problem only occurs if the guest panics _and_ has a guest
driver _and_ management knows to look at the crash event, so it is
mostly theoretical at this point in time.

Thus keep the code simple, and pretend it was never broken.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 392a4d5b9a1860aae82429d09321dac302d70396
      
https://github.com/qemu/qemu/commit/392a4d5b9a1860aae82429d09321dac302d70396
  Author: Peter Maydell <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M include/qemu/atomic.h

  Log Message:
  -----------
  atomic.h: Fix build with clang

clang defines __ATOMIC_SEQ_CST but its implementation of the
__atomic_exchange() builtin differs from that of gcc. Move the
__clang__ branch of the ifdef ladder to the top and fix its
implementation (there is no such builtin as __sync_exchange),
so we can compile with clang again.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 8d07d6c46597a885eb38d99cc6fff399ce69cd21
      
https://github.com/qemu/qemu/commit/8d07d6c46597a885eb38d99cc6fff399ce69cd21
  Author: Alex Williamson <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M hw/misc/vfio.c

  Log Message:
  -----------
  vfio-pci: Fix multifunction=on

When an assigned device is initialized it copies the device config
space into the emulated config space.  Unfortunately multifunction is
setup prior to the device initfn and gets clobbered.  We need to
restore it just like pci-assign does.

Cc: address@hidden
Signed-off-by: Alex Williamson <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 2140cfa51d59177815f5b82e94ac48fb24909aba
      
https://github.com/qemu/qemu/commit/2140cfa51d59177815f5b82e94ac48fb24909aba
  Author: Peter Maydell <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M target-i386/kvm-stub.c

  Log Message:
  -----------
  target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

Fix build failures with clang when KVM is not enabled by
providing a stub version of kvm_arch_get_supported_cpuid().
We retain the compile time check that this function isn't
called when CONFIG_KVM is not set by guarding the stub with
ifndef __OPTIMIZE__ (we assume that an optimizing build will
do sufficient constant folding and dead code elimination to
remove the calls before linking).

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 60aad298cb6de52f2716b2e82e1353ea9de95fd6
      
https://github.com/qemu/qemu/commit/60aad298cb6de52f2716b2e82e1353ea9de95fd6
  Author: Amos Kong <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M backends/rng-egd.c

  Log Message:
  -----------
  rng-egd: remove redundant free

We didn't set default chr_name, the free is redundant.

Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: fbdcec5c487685b46e78f1e40a236ebf83f862fa
      
https://github.com/qemu/qemu/commit/fbdcec5c487685b46e78f1e40a236ebf83f862fa
  Author: Amos Kong <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M backends/rng-egd.c

  Log Message:
  -----------
  rng-egd: offset the point when repeatedly read from the buffer

The buffer content might be read out more than once, currently
we just repeatedly read the first data block, buffer offset is
missing.

Cc: address@hidden
Signed-off-by: Amos Kong <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b5fc314bcbb80f76b8deaf23a4c45767b87f750b
      
https://github.com/qemu/qemu/commit/b5fc314bcbb80f76b8deaf23a4c45767b87f750b
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M target-i386/helper.h
    M target-i386/misc_helper.c
    M target-i386/translate.c

  Log Message:
  -----------
  target-i386: yield to another VCPU on PAUSE

After commit b1bbfe7 (aio / timers: On timer modification, qemu_notify
or aio_notify, 2013-08-21) FreeBSD guests report a huge slowdown.

The problem shows up as soon as FreeBSD turns out its periodic (~1 ms)
tick, but the timers are only the trigger for a pre-existing problem.

Before the offending patch, setting a timer did a timer_settime system call.

After, setting the timer exits the event loop (which uses poll) and
reenters it with a new deadline.  This does not cause any slowdown; the
difference is between one system call (timer_settime and a signal
delivery (SIGALRM) before the patch, and two system calls afterwards
(write to a pipe or eventfd + calling poll again when re-entering the
event loop).

Unfortunately, the exit/enter causes the main loop to grab the iothread
lock, which in turns kicks the VCPU thread out of execution.  This
causes TCG to execute the next VCPU in its round-robin scheduling of
VCPUS.  When the second VCPU is mostly unused, FreeBSD runs a "pause"
instruction in its idle loop which only burns cycles without any
progress.  As soon as the timer tick expires, the first VCPU runs
the interrupt handler but very soon it sets it again---and QEMU
then goes back doing nothing in the second VCPU.

The fix is to make the pause instruction do "cpu_loop_exit".

Reported-by: Luigi Rizzo <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b6a06e72ef5e66e539012f63fca52c161c0d2496
      
https://github.com/qemu/qemu/commit/b6a06e72ef5e66e539012f63fca52c161c0d2496
  Author: Hervé Poussineau <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M hw/mips/mips_jazz.c

  Log Message:
  -----------
  mips jazz: do not raise data bus exception when accessing invalid addresses

MIPS Jazz chipset doesn't seem to raise data bus exceptions on invalid accesses.
However, there is no easy way to prevent them. Creating a big memory region
for the whole address space doesn't prevent memory core to directly call
unassigned_mem_read/write which in turn call cpu->do_unassigned_access,
which (for MIPS CPU) raise an data bus exception.

This fixes a MIPS Jazz regression introduced in 
c658b94f6e8c206c59d02aa6fbac285b86b53d2c.

Signed-off-by: Hervé Poussineau <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: d607a52364e7bfc1cd6d3e425b898e86be4e525d
      
https://github.com/qemu/qemu/commit/d607a52364e7bfc1cd6d3e425b898e86be4e525d
  Author: Stefan Weil <address@hidden>
  Date:   2013-11-21 (Thu, 21 Nov 2013)

  Changed paths:
    M qga/commands-posix.c
    M qga/guest-agent-core.h

  Log Message:
  -----------
  qga: Fix compiler warnings (missing format attribute, wrong format strings)

gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):

  CC    qga/commands.o
qga/commands.c: In function ‘slog’:
qga/commands.c:28:5: error:
 function might be possible candidate for ‘gnu_printf’ format attribute 
[-Werror=suggest-attribute=format]
     g_logv("syslog", G_LOG_LEVEL_INFO, fmt, ap);
     ^

gcc 4.8.2 reports this warning when slog is declared with the
gnu_printf format attribute:

qga/commands-posix.c: In function ‘qmp_guest_file_open’:
qga/commands-posix.c:404:5: warning:
 format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘int64_t’ 
[-Wformat=]
     slog("guest-file-open, handle: %d", handle);
     ^

On 32 bit hosts there are three more warnings which are also fixed here.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 30c367ed446b6ea53245589a5cf373578ac075d7
      
https://github.com/qemu/qemu/commit/30c367ed446b6ea53245589a5cf373578ac075d7
  Author: Vlad Yasevich <address@hidden>
  Date:   2013-11-22 (Fri, 22 Nov 2013)

  Changed paths:
    M hw/core/qdev-properties-system.c

  Log Message:
  -----------
  qdev-properties-system.c: Allow vlan or netdev for -device, not both

It is currently possible to specify things like:
        -device e1000,netdev=foo,vlan=1
With this usage, whichever argument was specified last (vlan or netdev)
overwrites what was previousely set and results in a non-working
configuration.  Even worse, when used with multiqueue devices,
it causes a segmentation fault on exit in qemu_free_net_client.

That patch treates the above command line options as invalid and
generates an error at start-up.

Signed-off-by: Vlad Yasevich <address@hidden>
Acked-by: Jason Wang <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: bca4bf1028b332f55502bc7f50345fa5ea1c4f40
      
https://github.com/qemu/qemu/commit/bca4bf1028b332f55502bc7f50345fa5ea1c4f40
  Author: Tomoki Sekiyama <address@hidden>
  Date:   2013-11-22 (Fri, 22 Nov 2013)

  Changed paths:
    M qga/vss-win32/install.cpp

  Log Message:
  -----------
  qemu-ga: vss-win32: Install VSS provider COM+ application service

Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze when
no user is logging in to Windows, with an error message:
  {"error":{"class":"GenericError",
      "desc":"failed to add C:\\ to snapshotset:  (error: 8004230f)"}}

To enable guest-fsfreeze-freeze/thaw without logging in users, this installs
a service to execute qemu-ga VSS provider COM+ application that has full
access privileges to the local system. The service will automatically be
removed when the COM+ application is deregistered.

This patch replaces ICOMAdminCatalog interface with ICOMAdminCatalog2
interface that contains CreateServiceForApplication() method in addition.

Signed-off-by: Tomoki Sekiyama <address@hidden>
Reviewed-by: Gal Hammer <address@hidden>
Reviewed-by: Yan Vugenfirer <address@hidden>
Tested-by: Yan Vugenfirer <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: e007dbece5fc4e55e10116c6cb42753e35a945bf
      
https://github.com/qemu/qemu/commit/e007dbece5fc4e55e10116c6cb42753e35a945bf
  Author: Michael S. Tsirkin <address@hidden>
  Date:   2013-11-24 (Sun, 24 Nov 2013)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: make --iasl option actually work

--iasl option was added to CC option parsing section by mistake,
it's not effective there and attempts to use cause
an 'unknown option' error.

Fix this up.

Tested-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 0ff1e1dac4b6bccefc4b8a861ec2a643ecfb6e9d
      
https://github.com/qemu/qemu/commit/0ff1e1dac4b6bccefc4b8a861ec2a643ecfb6e9d
  Author: Anthony Liguori <address@hidden>
  Date:   2013-11-25 (Mon, 25 Nov 2013)

  Changed paths:
    M hw/core/qdev-properties-system.c

  Log Message:
  -----------
  Merge remote-tracking branch 'stefanha/net' into staging

# By Vlad Yasevich
# Via Stefan Hajnoczi
* stefanha/net:
  qdev-properties-system.c: Allow vlan or netdev for -device, not both

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 833637d46dd5a0859abdff085352ae7d48dc8189
      
https://github.com/qemu/qemu/commit/833637d46dd5a0859abdff085352ae7d48dc8189
  Author: Anthony Liguori <address@hidden>
  Date:   2013-11-25 (Mon, 25 Nov 2013)

  Changed paths:
    M qga/vss-win32/install.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'mdroth/qga-pull-2013-11-22' into staging

# By Tomoki Sekiyama
# Via Michael Roth
* mdroth/qga-pull-2013-11-22:
  qemu-ga: vss-win32: Install VSS provider COM+ application service

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: d916adaa606dd1b871316acb295d5979361133b7
      
https://github.com/qemu/qemu/commit/d916adaa606dd1b871316acb295d5979361133b7
  Author: Anthony Liguori <address@hidden>
  Date:   2013-11-25 (Mon, 25 Nov 2013)

  Changed paths:
    M Makefile
    M configure
    M hw/display/tcx.c
    M hw/i386/pc_piix.c
    M hw/i386/pc_q35.c
    M hw/misc/pvpanic.c
    M hw/sparc/sun4m.c
    M include/hw/i386/pc.h
    A pc-bios/QEMU,tcx.bin
    M pc-bios/README
    M qga/commands-posix.c
    M qga/guest-agent-core.h
    M target-i386/kvm-stub.c

  Log Message:
  -----------
  Merge remote-tracking branch 'bonzini/tags/for-anthony' into staging

Here are a bunch of 1.7-tagged patches that I was afraid
were getting forgotten or that did not have a clear maintainer responsible
for making a pull request.

# gpg: Signature made Thu 21 Nov 2013 08:40:59 AM PST using RSA key ID 9B4D86F2
# gpg: Can't check signature: public key not found

# By Peter Maydell (3) and others
# Via Paolo Bonzini
* bonzini/tags/for-anthony:
  qga: Fix compiler warnings (missing format attribute, wrong format strings)
  mips jazz: do not raise data bus exception when accessing invalid addresses
  target-i386: yield to another VCPU on PAUSE
  rng-egd: offset the point when repeatedly read from the buffer
  rng-egd: remove redundant free
  target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()
  vfio-pci: Fix multifunction=on
  atomic.h: Fix build with clang
  pc: get rid of builtin pvpanic for "-M pc-1.5"
  configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0
  sun4m: Add FCode ROM for TCX framebuffer

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: c0caec178eadbbac4c672110c3914313091e0588
      
https://github.com/qemu/qemu/commit/c0caec178eadbbac4c672110c3914313091e0588
  Author: Anthony Liguori <address@hidden>
  Date:   2013-11-25 (Mon, 25 Nov 2013)

  Changed paths:
    M configure
    M hw/net/e1000.c
    M hw/net/rtl8139.c
    M hw/pci/pci.c

  Log Message:
  -----------
  Merge remote-tracking branch 'mst/tags/for_anthony' into staging

pc very last minute fixes for 1.7

This has a fix for a crasher bug with pci bridges,
boot failure fix for s390 on 32 bit hosts,
and fixes build for hosts with old glib.

There's also a fix for --iasl configure flag - it can be used
to work around broken iasl on some systems either
by using a non-standard iasl or by disabling it.

I've also reverted a e1000/rtl mac programming change
that seems slightly wrong and too risky for 1.8.

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Mon 25 Nov 2013 03:40:07 AM PST using RSA key ID D28D5469
# gpg: Can't check signature: public key not found

# By Michael S. Tsirkin (5) and Bandan Das (1)
# Via Michael S. Tsirkin
* mst/tags/for_anthony:
  configure: make --iasl option actually work
  Revert "e1000/rtl8139: update HMP NIC when every bit is written"
  acpi-build: fix build on glib < 2.14
  acpi-build: fix build on glib < 2.22
  pci: unregister vmstate_pcibus on unplug
  s390x: fix flat file load on 32 bit systems

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/607bb022f2a4...c0caec178ead

reply via email to

[Prev in Thread] Current Thread [Next in Thread]