Re: [PATCH v3 04/16] aspeed/sdmc: fix coding style

[Cédric Le Goater]

On 4/16/24 11:18, Jamin Lin wrote:
> Fix coding style issues from checkpatch.pl
>
> Test command:
> scripts/checkpatch.pl --no-tree -f hw/misc/aspeed_sdmc.c
>
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> ---
>   hw/misc/aspeed_sdmc.c | 11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
> index 74279bbe8e..873d67c592 100644
> --- a/hw/misc/aspeed_sdmc.c
> +++ b/hw/misc/aspeed_sdmc.c
> @@ -296,7 +296,8 @@ static void aspeed_2400_sdmc_write(AspeedSDMCState *s, 
> uint32_t reg,
>                                      uint32_t data)
>   {
>       if (reg == R_PROT) {
> -        s->regs[reg] = (data == PROT_KEY_UNLOCK) ? PROT_UNLOCKED : 
> PROT_SOFTLOCKED;
> +        s->regs[reg] =
> +            (data == PROT_KEY_UNLOCK) ? PROT_UNLOCKED : PROT_SOFTLOCKED;
>           return;
>       }
>   
> @@ -354,7 +355,8 @@ static void aspeed_2500_sdmc_write(AspeedSDMCState *s, uint32_t reg,
>                                      uint32_t data)
>   {
>       if (reg == R_PROT) {
> -        s->regs[reg] = (data == PROT_KEY_UNLOCK) ? PROT_UNLOCKED : 
> PROT_SOFTLOCKED;
> +        s->regs[reg] =
> +            (data == PROT_KEY_UNLOCK) ? PROT_UNLOCKED : PROT_SOFTLOCKED;
>           return;
>       }
>   
> @@ -434,8 +436,9 @@ static void aspeed_2600_sdmc_write(AspeedSDMCState *s, uint32_t reg,
>       }
>   
>       if (s->regs[R_PROT] == PROT_HARDLOCKED) {
> -        qemu_log_mask(LOG_GUEST_ERROR, "%s: SDMC is locked until system 
> reset!\n",
> -                __func__);
> +        qemu_log_mask(LOG_GUEST_ERROR,
> +                      "%s: SDMC is locked until system reset!\n",
> +                      __func__);
>           return;
>       }
>