[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 03/19] tests: smbios: add test for legacy mode CLI options
From: |
Igor Mammedov |
Subject: |
[PATCH 03/19] tests: smbios: add test for legacy mode CLI options |
Date: |
Tue, 27 Feb 2024 16:47:33 +0100 |
Unfortunately having 2.0 machine type deprecated is not enough
to get rid of legacy SMBIOS handling since 'isapc' also uses
that and it's staying around.
Hence add test for CLI options handling to be sure that it
ain't broken during SMBIOS code refactoring.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/data/smbios/type11_blob.legacy | Bin 0 -> 10 bytes
tests/qtest/bios-tables-test.c | 17 +++++++++++++++++
2 files changed, 17 insertions(+)
create mode 100644 tests/data/smbios/type11_blob.legacy
diff --git a/tests/data/smbios/type11_blob.legacy
b/tests/data/smbios/type11_blob.legacy
new file mode 100644
index
0000000000000000000000000000000000000000..aef463aab903405958b0a85f85c5980671c08bee
GIT binary patch
literal 10
Rcmd;PW!S(N;u;*n000Tp0s;U4
literal 0
HcmV?d00001
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index a116f88e1d..d1ff4db7a2 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -2106,6 +2106,21 @@ static void test_acpi_pc_smbios_blob(void)
free_test_data(&data);
}
+static void test_acpi_isapc_smbios_legacy(void)
+{
+ uint8_t req_type11[] = { 1, 11 };
+ test_data data = {
+ .machine = "isapc",
+ .variant = ".pc_smbios_legacy",
+ .required_struct_types = req_type11,
+ .required_struct_types_len = ARRAY_SIZE(req_type11),
+ };
+
+ test_smbios("-smbios file=tests/data/smbios/type11_blob.legacy "
+ "-smbios type=1,family=TEST", &data);
+ free_test_data(&data);
+}
+
static void test_oem_fields(test_data *data)
{
int i;
@@ -2261,6 +2276,8 @@ int main(int argc, char *argv[])
test_acpi_pc_smbios_options);
qtest_add_func("acpi/piix4/smbios-blob",
test_acpi_pc_smbios_blob);
+ qtest_add_func("acpi/piix4/smbios-legacy",
+ test_acpi_isapc_smbios_legacy);
}
if (qtest_has_machine(MACHINE_Q35)) {
qtest_add_func("acpi/q35", test_acpi_q35_tcg);
--
2.39.3
- [PATCH 00/19] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS, Igor Mammedov, 2024/02/27
- [PATCH 01/19] tests: smbios: make it possible to write SMBIOS only test, Igor Mammedov, 2024/02/27
- [PATCH 03/19] tests: smbios: add test for legacy mode CLI options,
Igor Mammedov <=
- [PATCH 02/19] tests: smbios: add test for -smbios type=11 option, Igor Mammedov, 2024/02/27
- [PATCH 04/19] smbios: cleanup smbios_get_tables() from legacy handling, Igor Mammedov, 2024/02/27
- [PATCH 05/19] smbios: get rid of smbios_smp_sockets global, Igor Mammedov, 2024/02/27
- [PATCH 06/19] smbios: get rid of smbios_legacy global, Igor Mammedov, 2024/02/27