Re: [PATCH v6 02/41] Split out common part of peripherals

[Philippe Mathieu-Daudé]

On 26/2/24 01:02, Sergey Kambalin wrote:
> Pre-setup for BCM2838 introduction
>
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   hw/arm/bcm2835_peripherals.c         | 198 +++++++++++++++------------
>   hw/arm/bcm2836.c                     |  24 ++--
>   include/hw/arm/bcm2835_peripherals.h |  29 +++-
>   include/hw/arm/bcm2836.h             |   3 +-
>   4 files changed, 154 insertions(+), 100 deletions(-)
>
> diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
> index d5573fd954..ed38a08a57 100644
> --- a/hw/arm/bcm2835_peripherals.c
> +++ b/hw/arm/bcm2835_peripherals.c
> @@ -30,9 +30,9 @@
>   #define SEPARATE_DMA_IRQ_MAX 10
>   #define ORGATED_DMA_IRQ_COUNT 4
>   
> -static void create_unimp(BCM2835PeripheralState *ps,
> -                         UnimplementedDeviceState *uds,
> -                         const char *name, hwaddr ofs, hwaddr size)
> +void create_unimp(BCMSocPeripheralBaseState *ps,
> +                  UnimplementedDeviceState *uds,
> +                  const char *name, hwaddr ofs, hwaddr size)
>   {
>       object_initialize_child(OBJECT(ps), name, uds, TYPE_UNIMPLEMENTED_DEVICE);
>       qdev_prop_set_string(DEVICE(uds), "name", name);


> diff --git a/include/hw/arm/bcm2835_peripherals.h 
> b/include/hw/arm/bcm2835_peripherals.h
> index 0203bb79d8..1fc96218f8 100644
> --- a/include/hw/arm/bcm2835_peripherals.h
> +++ b/include/hw/arm/bcm2835_peripherals.h
> @@ -35,10 +35,13 @@
>   #include "hw/misc/unimp.h"


> +void create_unimp(BCMSocPeripheralBaseState *ps,
> +                  UnimplementedDeviceState *uds,
> +                  const char *name, hwaddr ofs, hwaddr size);

Note for Peter, we should officialize this create_unimp() in "unimp.h",
all we need is the parent object and MR pointer.

> +void bcm_soc_peripherals_common_realize(DeviceState *dev, Error **errp);
> +
>   #endif /* BCM2835_PERIPHERALS_H */