[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 06/22] target/arm: Add support for Non-maskable Interr
From: |
Jinjie Ruan |
Subject: |
Re: [RFC PATCH v2 06/22] target/arm: Add support for Non-maskable Interrupt |
Date: |
Thu, 22 Feb 2024 17:26:33 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 |
On 2024/2/22 5:23, Richard Henderson wrote:
> On 2/21/24 03:08, Jinjie Ruan via wrote:
>> This only implements the external delivery method via the GICv3.
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>> target/arm/cpu-qom.h | 3 ++-
>> target/arm/cpu.c | 39 ++++++++++++++++++++++++++++++++++-----
>> target/arm/cpu.h | 2 ++
>> target/arm/helper.c | 1 +
>> 4 files changed, 39 insertions(+), 6 deletions(-)
>>
>> diff --git a/target/arm/cpu-qom.h b/target/arm/cpu-qom.h
>> index 8e032691db..66d555a605 100644
>> --- a/target/arm/cpu-qom.h
>> +++ b/target/arm/cpu-qom.h
>> @@ -36,11 +36,12 @@ DECLARE_CLASS_CHECKERS(AArch64CPUClass, AARCH64_CPU,
>> #define ARM_CPU_TYPE_SUFFIX "-" TYPE_ARM_CPU
>> #define ARM_CPU_TYPE_NAME(name) (name ARM_CPU_TYPE_SUFFIX)
>> -/* Meanings of the ARMCPU object's four inbound GPIO lines */
>> +/* Meanings of the ARMCPU object's five inbound GPIO lines */
>> #define ARM_CPU_IRQ 0
>> #define ARM_CPU_FIQ 1
>> #define ARM_CPU_VIRQ 2
>> #define ARM_CPU_VFIQ 3
>> +#define ARM_CPU_NMI 4
>
> You need a 6th GPIO for vNMI.
Thank you! I'll fix it.
>
>
> r~
- [RFC PATCH v2 07/22] target/arm: Add support for NMI event state, (continued)
[RFC PATCH v2 06/22] target/arm: Add support for Non-maskable Interrupt, Jinjie Ruan, 2024/02/21
[RFC PATCH v2 16/22] hw/intc/arm_gicv3: Implement GICD_INMIR, Jinjie Ruan, 2024/02/21
[RFC PATCH v2 09/22] target/arm: Add support for FEAT_NMI, Non-maskable Interrupt, Jinjie Ruan, 2024/02/21
[RFC PATCH v2 05/22] target/arm: Support MSR access to ALLINT, Jinjie Ruan, 2024/02/21
[RFC PATCH v2 13/22] hw/intc/arm_gicv3: Add external IRQ lines for NMI, Jinjie Ruan, 2024/02/21
[RFC PATCH v2 22/22] hw/intc/arm_gicv3: Report the NMI interrupt in gicv3_cpuif_update(), Jinjie Ruan, 2024/02/21
[RFC PATCH v2 20/22] hw/intc/arm_gicv3: Add NMI handling CPU interface registers, Jinjie Ruan, 2024/02/21