Re: [PATCH 4/4] hw/arm/stellaris: Add missing QOM 'SoC' parent

[Philippe Mathieu-Daudé]

On 1/2/24 17:46, Peter Maydell wrote:
> On Tue, 30 Jan 2024 at 19:03, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > QDev objects created with qdev_new() need to manually add
> > their parent relationship with object_property_add_child().
> >
> > Since we don't model the SoC, just use a QOM container.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
>
> Ah, this is where the other qdev_new() calls are sorted.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> I wonder if we should add a variant on qdev_new() that
> you can pass in the parent object to?

Yes, this is what we discussed with Markus. In order to
stop using the "/unattached" container from pre-QOM,
qdev_new() must take a QOM parent. I tried to do it but hit
some problem with some odd use in PPC or S390 (discussed
with Cédric so likely PPC, I need to go back to it).