qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/8] hw/pci-host/designware: Initialize root function in host


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/8] hw/pci-host/designware: Initialize root function in host bridge realize
Date: Tue, 6 Feb 2024 17:35:59 +0100
User-agent: Mozilla Thunderbird

Hi Peter,

On 17/10/23 18:32, Peter Maydell wrote:
On Thu, 12 Oct 2023 at 13:19, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

There are no root function properties exposed by the host
bridge, so using a 2-step QOM creation isn't really useful.

Simplify by creating the root function when the host bridge
is realized.

It's not necessary, but on the other hand "init child objects
in init; realize child objects in realize" is the standard
way to do this. Does not moving this to the realize method
block anything in the rest of the patchset?

I thought it was only recommended to use the init/realize
pair when properties could be consumed. Otherwise using
a single handler makes a model simpler.

No problem if I can drop this patch.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]