[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/6] hw/xen: convert stderr prints to error/warn reports
From: |
Alex Bennée |
Subject: |
Re: [PATCH v3 6/6] hw/xen: convert stderr prints to error/warn reports |
Date: |
Tue, 30 Jan 2024 10:07:39 +0000 |
User-agent: |
mu4e 1.11.27; emacs 29.1 |
Manos Pitsidianakis <manos.pitsidianakis@linaro.org> writes:
> According to the QEMU Coding Style document:
>
>> Do not use printf(), fprintf() or monitor_printf(). Instead, use
>> error_report() or error_vreport() from error-report.h. This ensures the
>> error is reported in the right place (current monitor or stderr), and in
>> a uniform format.
>> Use error_printf() & friends to print additional information.
>
> This commit changes fprintfs that report warnings and errors to the
> appropriate report functions.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- Re: [PATCH v3 1/6] hw/arm/strongarm.c: convert DPRINTF to trace events and guest errors, (continued)
- [PATCH v3 2/6] hw/arm/z2: convert DPRINTF to trace events and guest errors, Manos Pitsidianakis, 2024/01/29
- [PATCH v3 3/6] hw/arm/xen_arm.c: convert DPRINTF to trace events and error/warn reports, Manos Pitsidianakis, 2024/01/29
- [PATCH v3 4/6] hw/xen/xen-mapcache.c: convert DPRINTF to tracepoints, Manos Pitsidianakis, 2024/01/29
- [PATCH v3 5/6] hw/xen/xen-hvm-common.c: convert DPRINTF to tracepoints, Manos Pitsidianakis, 2024/01/29
- [PATCH v3 6/6] hw/xen: convert stderr prints to error/warn reports, Manos Pitsidianakis, 2024/01/29
- Re: [PATCH v3 6/6] hw/xen: convert stderr prints to error/warn reports,
Alex Bennée <=