[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v13 1/9] hw/misc: Add Nuvoton's PCI Mailbox Module
From: |
Peter Maydell |
Subject: |
Re: [PATCH v13 1/9] hw/misc: Add Nuvoton's PCI Mailbox Module |
Date: |
Sat, 20 Jan 2024 11:30:08 +0000 |
On Fri, 19 Jan 2024 at 20:33, Nabih Estefan <nabihestefan@google.com> wrote:
>
> From: Hao Wu <wuhaotsh@google.com>
>
> The PCI Mailbox Module is a high-bandwidth communcation module
> between a Nuvoton BMC and CPU. It features 16KB RAM that are both
> accessible by the BMC and core CPU. and supports interrupt for
> both sides.
>
> This patch implements the BMC side of the PCI mailbox module.
> Communication with the core CPU is emulated via a chardev and
> will be in a follow-up patch.
>
> Change-Id: Iaca22f81c4526927d437aa367079ed038faf43f2
> Signed-off-by: Hao Wu <wuhaotsh@google.com>
> Signed-off-by: Nabih Estefan <nabihestefan@google.com>
> Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
Can we have a comment or other documentation defining what
the protocol expected on the chardev device is, please?
Without that it's hard to review to see whether the
implementation is doing what it is supposed to.
thanks
-- PMM
- [PATCH v13 0/9] Implementation of NPI Mailbox and GMAC Networking Module, Nabih Estefan, 2024/01/19
- [PATCH v13 1/9] hw/misc: Add Nuvoton's PCI Mailbox Module, Nabih Estefan, 2024/01/19
- Re: [PATCH v13 1/9] hw/misc: Add Nuvoton's PCI Mailbox Module,
Peter Maydell <=
- [PATCH v13 3/9] hw/misc: Add qtest for NPCM7xx PCI Mailbox, Nabih Estefan, 2024/01/19
- [PATCH v13 2/9] hw/arm: Add PCI mailbox module to Nuvoton SoC, Nabih Estefan, 2024/01/19
- [PATCH v13 5/9] hw/arm: Add GMAC devices to NPCM7XX SoC, Nabih Estefan, 2024/01/19
- [PATCH v13 4/9] hw/net: Add NPCMXXX GMAC device, Nabih Estefan, 2024/01/19
- [PATCH v13 6/9] tests/qtest: Creating qtest for GMAC Module, Nabih Estefan, 2024/01/19
- [PATCH v13 7/9] hw/net: GMAC Rx Implementation, Nabih Estefan, 2024/01/19
- [PATCH v13 8/9] hw/net: GMAC Tx Implementation, Nabih Estefan, 2024/01/19
- [PATCH v13 9/9] tests/qtest: Adding PCS Module test to GMAC Qtest, Nabih Estefan, 2024/01/19