[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase
|
From: |
Thomas Huth |
|
Subject: |
Re: [RFC 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase |
|
Date: |
Mon, 15 Jan 2024 06:52:58 +0100 |
|
User-agent: |
Mozilla Thunderbird |
Hi!
On 12/01/2024 18.05, Inès Varhol wrote:
Signed-off-by: Arnaud Minier <arnaud.minier@telecom-paris.fr>
Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
---
Maybe add a short patch description (e.g. saying what aspects of the GPIOs
are tested here)?
diff --git a/tests/qtest/stm32l4x5_gpio-test.c
b/tests/qtest/stm32l4x5_gpio-test.c
new file mode 100644
index 0000000000..189083bc4f
--- /dev/null
+++ b/tests/qtest/stm32l4x5_gpio-test.c
...
+static void test_idr_reset_value(void)
+{
+ /*
+ * Check that IDR register as well as other registers
+ * determining its value have the exepcted value
s/exepcted/expected/
+ * GPIOA->IDR value after reset is not identical
+ * to the real one ad Alternate Functions aren't
s/ad/and/ ?
+ * implemented
+ */
With the typos fixed:
Acked-by: Thomas Huth <thuth@redhat.com>