Re: [PATCH] tests/tcg: Don't #include <inttypes.h> in aarch64/system/vtimer.c

[Philippe Mathieu-Daudé]

Hi Ilya,

On 8/1/24 13:50, Ilya Leoshkevich wrote:
> make check-tcg fails on Fedora with:
>
>      vtimer.c:9:10: fatal error: inttypes.h: No such file or directory
>
> Fedora has a minimal aarch64 cross-compiler, which satisfies the
> configure checks, so it's chosen instead of the dockerized one.
> There is no cross-version of inttypes.h, however.

Presumably this isn't specific to aarch64 target, so what about
the other uses, shouldn't we clean all similar uses at once?

$ git grep inttypes.h tests/tcg | wc -l
      26

> Fix by using stdint.h instead. The test does not require anything
> from inttypes.h anyway.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>   tests/tcg/aarch64/system/vtimer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/aarch64/system/vtimer.c 
> b/tests/tcg/aarch64/system/vtimer.c
> index 42f2f7796c7..7d725eced34 100644
> --- a/tests/tcg/aarch64/system/vtimer.c
> +++ b/tests/tcg/aarch64/system/vtimer.c
> @@ -6,7 +6,7 @@
>    * SPDX-License-Identifier: GPL-2.0-or-later
>    */
>   
> -#include <inttypes.h>
> +#include <stdint.h>
>   #include <minilib.h>
>   
>   /* grabbed from Linux */