Re: [PATCH] hw/arm: add PCIe to Freescale i.MX6

[Philippe Mathieu-Daudé]

Hi Nikita,

On 7/1/24 17:57, Nikita Ostrenkov wrote:
> Signed-off-by: Nikita Ostrenkov <n.ostrenkov@gmail.com>
> ---
>   hw/arm/Kconfig            |  3 +++
>   hw/arm/fsl-imx6.c         | 25 ++++++++++++++++++++++
>   include/hw/arm/fsl-imx6.h | 44 ++++++++++++++++++++-------------------
>   3 files changed, 51 insertions(+), 21 deletions(-)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 660f49db49..575bb68c76 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -530,13 +530,16 @@ config FSL_IMX31
>   
>   config FSL_IMX6
>       bool
> +    imply PCI_DEVICES

This should be PCIE_DEVICES.

>       imply I2C_DEVICES
>       select A9MPCORE
> +    select PCI

Incorrect, should be PCI_EXPRESS, but this is already
(indirectly) selected by PCI_EXPRESS_DESIGNWARE which
you select below, so not needed.

>       select IMX
>       select IMX_FEC
>       select IMX_I2C
>       select IMX_USBPHY
>       select WDT_IMX2
> +    select PCI_EXPRESS_DESIGNWARE
>       select SDHCI