Re: [PATCH v2 4/7] tests/avocado: drop malta yamon tests

[Philippe Mathieu-Daudé]

Hi Alex,

On 1/12/23 13:49, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > Hi Alex,
> >
> > On 1/12/23 10:36, Alex Bennée wrote:
> > > The assets are no longer available on the website so these are
> > > blocking CI.
> >
> > How are these "blocking CI"? Missing artifact wasn't be fatal,
> > is it now? Also, did the artifact cache got flushed? These tests
> > pass locally, I disagree with removing them.
> >
> > I can send a patch using YAMON_PATH like we have with RESCUE_YL_PATH,
> > but I still consider missing artifact shouldn't be an issue. We are
> > missing the point of the Avocado cache and the possibility to manually
> > add artifacts.
>
> Sure but in this case the binaries are gone, you can't share them and no
> one else can ever run the test. At that point it just becomes dead
> weight in the repository. This doesn't stop you keeping your own branch
> where old tests live on while close to a warm cache but it does somewhat
> limit the use of the test to the wider community.

No, I still disagree. The tests/avocado/ directory started as a place
to share tests, not to add CI gating tests. That was discussed again
2 or 3 years ago, we even recommended to change from the "opt-out on CI"
policy to the "opt-in for Gating CI". Daniel suggested the Tiers
approach, having only Tier-1 gating.

I think the mistake is to consider all tests as gating.

Why don't you want to share QEMU tests in the QEMU repository?

We might have some misunderstanding on what tests/ is for, so let's
discuss...

Regards,

Phil.