qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] hw: Replace anti-social QOM type names (again)


From: Thomas Huth
Subject: Re: [PATCH 2/2] hw: Replace anti-social QOM type names (again)
Date: Mon, 13 Nov 2023 17:06:52 +0100
User-agent: Mozilla Thunderbird

On 13/11/2023 14.43, Markus Armbruster wrote:
QOM type names containing ',' result in awful UI.  We got rid of them
in v6.0.0 (commit e178113ff64 hw: Replace anti-social QOM type names).
A few have crept back since:

     xlnx,cframe-reg
     xlnx,efuse
     xlnx,pmc-efuse-cache
     xlnx,versal-cfu-apb
     xlnx,versal-cfu-fdro
     xlnx,versal-cfu-sfr
     xlnx,versal-crl
     xlnx,versal-efuse
     xlnx,zynqmp-efuse

These are all device types.  They can't be plugged with -device /
device_add, except for "xlnx,efuse" (I'm not sure that one is
intentional).

They *can* be used with -device / device_add to request help.
Usability is poor, though: you have to double the comma, like this:

     $ qemu-system-aarch64 -device xlnx,,pmc-efuse-cache,help

They can also be used with -global, where you must *not* double the
comma:

     $ qemu-system-aarch64 -global xlnx,efuse.drive-index=2

Trap for the unwary.

"xlnx,efuse", "xlnx,versal-efuse", "xlnx,pmc-efuse-cache",
"xlnx-zynqmp-efuse" are from v6.2.0, "xlnx,versal-crl" is from v7.1.0,
and the remainder are new.

Rename them all to "xlnx-FOO", like commit e178113ff64 did.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
  docs/system/arm/xlnx-versal-virt.rst     | 2 +-
  include/hw/misc/xlnx-versal-cframe-reg.h | 2 +-
  include/hw/misc/xlnx-versal-cfu.h        | 6 +++---
  include/hw/misc/xlnx-versal-crl.h        | 2 +-
  include/hw/nvram/xlnx-efuse.h            | 2 +-
  include/hw/nvram/xlnx-versal-efuse.h     | 4 ++--
  include/hw/nvram/xlnx-zynqmp-efuse.h     | 2 +-
  7 files changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]