Re: [PATCH 0/6] arm/stellaris: convert gamepad input device to qdev

[Philippe Mathieu-Daudé]

On 30/10/23 12:29, Peter Maydell wrote:
> On Mon, 30 Oct 2023 at 10:39, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > On 17/10/23 14:22, Peter Maydell wrote:
> > > (I had this all ready to go before I went off on holiday two
> > > weeks ago, except I forgot to actually *send* the emails...)
> > >
> > > This patchseries converts the stellaris board's gamepad input device
> > > to qdev. This isn't a very important bit of conversion (I was just
> > > looking for a small tail-end-of-the-week task), but it does reduce by
> > > one the number of users of a couple of legacy APIs: vmstate_register()
> > > and qemu_add_kbd_event_handler().
> > >
> > > I've included Kevin's qdev_prop_set_array() patch here, because I
> > > wanted an array property and it doesn't seem sensible to write it the
> > > old way and have another thing that needs converting. I'm assuming
> > > that by the time this patchset gets reviewed and committed that
> > > one will already be upstream.
> > >
> > > thanks
> > > -- PMM
> > >
> > > Kevin Wolf (1):
> > >     qdev: Add qdev_prop_set_array()
> > >
> > > Peter Maydell (5):
> > >     hw/input/stellaris_input: Rename to stellaris_gamepad
> > >     hw/input/stellaris_gamepad: Rename structs to our usual convention
> > >     hw/input/stellaris_gamepad: Remove StellarisGamepadButton struct
> > >     hw/input/stellaris_input: Convert to qdev
> > >     hw/input/stellaris_gamepad: Convert to qemu_input_handler_register()
> >
> > Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Thanks. I actually have a v2 of this ready but am waiting on a decision
> about whether the qdev_prop_set_array() API is OK before I send it.

Oh we just crossed then :)

I'm happy with qdev_prop_set_array() for our needs but I don't think
you are waiting for my particular input there, rather Kevin / Markus.