[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V6 7/9] hw/acpi: Update ACPI GED framework to support vCPU Ho
From: |
Igor Mammedov |
Subject: |
Re: [PATCH V6 7/9] hw/acpi: Update ACPI GED framework to support vCPU Hotplug |
Date: |
Fri, 27 Oct 2023 15:18:28 +0200 |
On Fri, 13 Oct 2023 11:51:27 +0100
Salil Mehta <salil.mehta@huawei.com> wrote:
> ACPI GED shall be used to convey to the guest kernel about any CPU
> hot-(un)plug
> events. Therefore, existing ACPI GED framework inside QEMU needs to be
> enhanced
> to support CPU hotplug state and events.
>
This is a part of hw wiring which you started to introduce in 4/9
Given patches are small, I'd merge this into 4/9 to avoid broken context.
So essentially GED improvement would consist from hw and aml parts.
with some extra refactoring (5/9) in a separate patch.
> Co-developed-by: Keqian Zhu <zhukeqian1@huawei.com>
> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
> Tested-by: Vishnu Pajjuri <vishnu@os.amperecomputing.com>
> Tested-by: Xianglai Li <lixianglai@loongson.cn>
> ---
> hw/acpi/generic_event_device.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> index 62d504d231..0d5f0140e5 100644
> --- a/hw/acpi/generic_event_device.c
> +++ b/hw/acpi/generic_event_device.c
> @@ -12,6 +12,7 @@
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> #include "hw/acpi/acpi.h"
> +#include "hw/acpi/cpu.h"
> #include "hw/acpi/generic_event_device.h"
> #include "hw/irq.h"
> #include "hw/mem/pc-dimm.h"
> @@ -239,6 +240,8 @@ static void acpi_ged_device_plug_cb(HotplugHandler
> *hotplug_dev,
> } else {
> acpi_memory_plug_cb(hotplug_dev, &s->memhp_state, dev, errp);
> }
> + } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
> + acpi_cpu_plug_cb(hotplug_dev, &s->cpuhp_state, dev, errp);
> } else {
> error_setg(errp, "virt: device plug request for unsupported device"
> " type: %s", object_get_typename(OBJECT(dev)));
> @@ -253,6 +256,8 @@ static void acpi_ged_unplug_request_cb(HotplugHandler
> *hotplug_dev,
> if ((object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) &&
> !(object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)))) {
> acpi_memory_unplug_request_cb(hotplug_dev, &s->memhp_state, dev,
> errp);
> + } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
> + acpi_cpu_unplug_request_cb(hotplug_dev, &s->cpuhp_state, dev, errp);
> } else {
> error_setg(errp, "acpi: device unplug request for unsupported device"
> " type: %s", object_get_typename(OBJECT(dev)));
> @@ -266,6 +271,8 @@ static void acpi_ged_unplug_cb(HotplugHandler
> *hotplug_dev,
>
> if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) {
> acpi_memory_unplug_cb(&s->memhp_state, dev, errp);
> + } else if (object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
> + acpi_cpu_unplug_cb(&s->cpuhp_state, dev, errp);
> } else {
> error_setg(errp, "acpi: device unplug for unsupported device"
> " type: %s", object_get_typename(OBJECT(dev)));
> @@ -277,6 +284,7 @@ static void acpi_ged_ospm_status(AcpiDeviceIf *adev,
> ACPIOSTInfoList ***list)
> AcpiGedState *s = ACPI_GED(adev);
>
> acpi_memory_ospm_status(&s->memhp_state, list);
> + acpi_cpu_ospm_status(&s->cpuhp_state, list);
> }
>
> static void acpi_ged_send_event(AcpiDeviceIf *adev, AcpiEventStatusBits ev)
> @@ -291,6 +299,8 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev,
> AcpiEventStatusBits ev)
> sel = ACPI_GED_PWR_DOWN_EVT;
> } else if (ev & ACPI_NVDIMM_HOTPLUG_STATUS) {
> sel = ACPI_GED_NVDIMM_HOTPLUG_EVT;
> + } else if (ev & ACPI_CPU_HOTPLUG_STATUS) {
> + sel = ACPI_GED_CPU_HOTPLUG_EVT;
> } else {
> /* Unknown event. Return without generating interrupt. */
> warn_report("GED: Unsupported event %d. No irq injected", ev);
- [PATCH V6 3/9] hw/acpi: Add ACPI CPU hotplug init stub, (continued)
- [PATCH V6 3/9] hw/acpi: Add ACPI CPU hotplug init stub, Salil Mehta, 2023/10/13
- [PATCH V6 4/9] hw/acpi: Init GED framework with CPU hotplug events, Salil Mehta, 2023/10/13
- [PATCH V6 5/9] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change, Salil Mehta, 2023/10/13
- [PATCH V6 6/9] hw/acpi: Update GED _EVT method AML with CPU scan, Salil Mehta, 2023/10/13
- [PATCH V6 7/9] hw/acpi: Update ACPI GED framework to support vCPU Hotplug, Salil Mehta, 2023/10/13
- Re: [PATCH V6 7/9] hw/acpi: Update ACPI GED framework to support vCPU Hotplug,
Igor Mammedov <=
- [PATCH V6 8/9] physmem: Add helper function to destroy CPU AddressSpace, Salil Mehta, 2023/10/13
- [PATCH V6 9/9] gdbstub: Add helper function to unregister GDB register space, Salil Mehta, 2023/10/13
- Re: [PATCH V6 0/9] Add architecture agnostic code to support vCPU Hotplug, Miguel Luis, 2023/10/13
- Re: [PATCH V6 0/9] Add architecture agnostic code to support vCPU Hotplug, Shaoqin Huang, 2023/10/19