Re: [PATCH V3 03/10] hw/acpi: Add ACPI CPU hotplug init stub

[David Hildenbrand]

On 09.10.23 15:49, Salil Mehta wrote:
> > From: David Hildenbrand <david@redhat.com>
> > Sent: Monday, October 9, 2023 1:23 PM
> > To: Salil Mehta <salil.mehta@huawei.com>; qemu-devel@nongnu.org; qemu-
> > arm@nongnu.org
> > Cc: maz@kernel.org; jean-philippe@linaro.org; Jonathan Cameron
> > <jonathan.cameron@huawei.com>; lpieralisi@kernel.org;
> > peter.maydell@linaro.org; richard.henderson@linaro.org;
> > imammedo@redhat.com; andrew.jones@linux.dev; philmd@linaro.org;
> > eric.auger@redhat.com; oliver.upton@linux.dev; pbonzini@redhat.com;
> > mst@redhat.com; will@kernel.org; gshan@redhat.com; rafael@kernel.org;
> > alex.bennee@linaro.org; linux@armlinux.org.uk;
> > darren@os.amperecomputing.com; ilkka@os.amperecomputing.com;
> > vishnu@os.amperecomputing.com; karl.heubaum@oracle.com;
> > miguel.luis@oracle.com; salil.mehta@opnsrc.net; zhukeqian
> > <zhukeqian1@huawei.com>; wangxiongfeng (C) <wangxiongfeng2@huawei.com>;
> > wangyanan (Y) <wangyanan55@huawei.com>; jiakernel2@gmail.com;
> > maobibo@loongson.cn; lixianglai@loongson.cn; Linuxarm <linuxarm@huawei.com>
> > Subject: Re: [PATCH V3 03/10] hw/acpi: Add ACPI CPU hotplug init stub
> >
> > On 09.10.23 13:28, Salil Mehta wrote:
> > > ACPI CPU hotplug related initialization should only happen if
> > ACPI_CPU_HOTPLUG
> > > support has been enabled for particular architecture. Add
> > cpu_hotplug_hw_init()
> > > stub to avoid compilation break.
> > >
> > > Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > Reviewed-by: Gavin Shan <gshan@redhat.com>
> > > ---
> > >    hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++
> > >    1 file changed, 6 insertions(+)
> > >
> > > diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug-
> > stub.c
> > > index 3fc4b14c26..c6c61bb9cd 100644
> > > --- a/hw/acpi/acpi-cpu-hotplug-stub.c
> > > +++ b/hw/acpi/acpi-cpu-hotplug-stub.c
> > > @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion
> > *parent, Object *owner,
> > >        return;
> > >    }
> > >
> > > +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,
> > > +                         CPUHotplugState *state, hwaddr base_addr)
> > > +{
> > > +    return;
> > > +}
> >
> > While at it, can we prefix that function with acpi?
>
> I can do that but it has to be done at other places as well
> such as in hw/acpi/cpu_hotplug.c <acpi_switch_to_modern_cphp()>

$ git grep cpu_hotplug_hw_init
hw/acpi/cpu.c:void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,
hw/acpi/cpu_hotplug.c:    cpu_hotplug_hw_init(parent, gpe_cpu->device, 
cpuhp_state, io_port);
include/hw/acpi/cpu.h:void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,

Might want to do that as a separate patch, agreed.

--
Cheers,

David / dhildenb