qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 5/7] aspeed: Create flash devices only when defaults are e


From: Cédric Le Goater
Subject: Re: [PATCH v3 5/7] aspeed: Create flash devices only when defaults are enabled
Date: Thu, 31 Aug 2023 18:55:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 8/31/23 15:42, Joel Stanley wrote:
On Thu, 31 Aug 2023 at 13:22, Cédric Le Goater <clg@kaod.org> wrote:

On 8/31/23 15:00, Joel Stanley wrote:
On Thu, 31 Aug 2023 at 12:39, Cédric Le Goater <clg@kaod.org> wrote:

When the -nodefaults option is set, flash devices should be created
with :

      -blockdev node-name=fmc0,driver=file,filename=./flash.img \
      -device mx66u51235f,cs=0x0,bus=ssi.0,drive=fmc0 \

To be noted that in this case, the ROM will not be installed and the
initial boot sequence (U-Boot loading) will fetch instructions using
SPI transactions which is significantly slower. That's exactly how HW
operates though.

Signed-off-by: Cédric Le Goater <clg@kaod.org>

I think this is the first foray for the aspeed machines into
nodefaults removing things that previously would have just worked.

This is true. It is change from the previous behavior.

QEMU should probably complain if no fmc0 are found to boot from.
Would that be ok ? And yes, documentation needs some update.

I didn't consider warning. That would help users who blindly added
-nodefaults and wondered why nothing was happening.

This is what happens if you add -nodefaults to an "old" command line
with your patch applied:

$ ./build/qemu-system-arm -M rainier-bmc -nographic -nodefaults
-serial stdio -drive
file=obmc-phosphor-image-rainier.static.mtd,if=mtd,format=raw
qemu-system-arm: -drive
file=obmc-phosphor-image-rainier.static.mtd,if=mtd,format=raw: machine
type does not support if=mtd,bus=0,unit=0

yes that's a post board init sanity check on unused drives.
Which at least isn't sitting there spinning, as I was worried. I'll
leave it to you as to whether it needs a helpful message.

It seems difficult since we could be booting the machine from a kernel also.

I will update the documentation.

Thanks,

C.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]