qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 0/7] Introduce model for IBM's FSP


From: Ninad Palsule
Subject: Re: [PATCH v1 0/7] Introduce model for IBM's FSP
Date: Tue, 29 Aug 2023 21:30:06 -0500
User-agent: Mozilla Thunderbird

Hello Cedric,

On 8/28/23 03:49, Cédric Le Goater wrote:
Hello Ninad,

On 8/25/23 22:30, Ninad Palsule wrote:
Hello,

Please review the patch-set.

This is a first step towards introducing model for IBM's Flexible
Service Interface. The full functionality will be implemented over the
time.

Ninad Palsule (7):
   hw/fsi: Introduce IBM's Local bus
   hw/fsi: Introduce IBM's scratchpad
   hw/fsi: Introduce IBM's cfam,fsi-slave
   hw/fsi: Introduce IBM's FSI
   hw/fsi: IBM's On-chip Peripheral Bus
   hw/fsi: Aspeed APB2OPB interface
   hw/arm: Hook up FSI module in AST2600

  hw/Kconfig                         |   1 +
  hw/arm/Kconfig                     |   1 +
  hw/arm/aspeed_ast2600.c            |  15 ++
  hw/fsi/Kconfig                     |  23 ++
  hw/fsi/aspeed-apb2opb.c            | 346 +++++++++++++++++++++++++++++
  hw/fsi/cfam.c                      | 236 ++++++++++++++++++++
  hw/fsi/engine-scratchpad.c         | 100 +++++++++
  hw/fsi/fsi-master.c                | 202 +++++++++++++++++
  hw/fsi/fsi-slave.c                 | 109 +++++++++
  hw/fsi/fsi.c                       |  54 +++++
  hw/fsi/lbus.c                      |  94 ++++++++
  hw/fsi/meson.build                 |   6 +
  hw/fsi/opb.c                       | 194 ++++++++++++++++
  hw/fsi/trace-events                |   2 +
  hw/fsi/trace.h                     |   1 +
  hw/meson.build                     |   1 +
  include/hw/arm/aspeed_soc.h        |   4 +
  include/hw/fsi/aspeed-apb2opb.h    |  32 +++
  include/hw/fsi/bits.h              |  15 ++
  include/hw/fsi/cfam.h              |  59 +++++
  include/hw/fsi/engine-scratchpad.h |  32 +++
  include/hw/fsi/fsi-master.h        |  30 +++
  include/hw/fsi/fsi-slave.h         |  29 +++
  include/hw/fsi/fsi.h               |  35 +++
  include/hw/fsi/lbus.h              |  57 +++++
  include/hw/fsi/opb.h               |  45 ++++
  meson.build                        |   1 +

Thanks for creating a series for these models.

I think the commit logs have a lot of useful information which would
be good for some docs/specs/ file. Please add a need a entry in
MAINTAINERS for this new bus model.

Tests are *very* much welcome also. Ideally we should have a couple
in qtest. A minimum would be an avocado test running pdbg.

I have added document, MAINTAINERS and qtest.

Thank you for the review.

~Ninad


Thanks,

C.



  27 files changed, 1724 insertions(+)
  create mode 100644 hw/fsi/Kconfig
  create mode 100644 hw/fsi/aspeed-apb2opb.c
  create mode 100644 hw/fsi/cfam.c
  create mode 100644 hw/fsi/engine-scratchpad.c
  create mode 100644 hw/fsi/fsi-master.c
  create mode 100644 hw/fsi/fsi-slave.c
  create mode 100644 hw/fsi/fsi.c
  create mode 100644 hw/fsi/lbus.c
  create mode 100644 hw/fsi/meson.build
  create mode 100644 hw/fsi/opb.c
  create mode 100644 hw/fsi/trace-events
  create mode 100644 hw/fsi/trace.h
  create mode 100644 include/hw/fsi/aspeed-apb2opb.h
  create mode 100644 include/hw/fsi/bits.h
  create mode 100644 include/hw/fsi/cfam.h
  create mode 100644 include/hw/fsi/engine-scratchpad.h
  create mode 100644 include/hw/fsi/fsi-master.h
  create mode 100644 include/hw/fsi/fsi-slave.h
  create mode 100644 include/hw/fsi/fsi.h
  create mode 100644 include/hw/fsi/lbus.h
  create mode 100644 include/hw/fsi/opb.h





reply via email to

[Prev in Thread] Current Thread [Next in Thread]