Re: [PATCH 21/44] Add clock_isp stub

[Peter Maydell]

On Wed, 26 Jul 2023 at 14:55, Sergey Kambalin <serg.oker@gmail.com> wrote:
>
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> ---
>  hw/arm/bcm2838_peripherals.c         | 6 ++++++
>  include/hw/arm/bcm2838_peripherals.h | 1 +
>  2 files changed, 7 insertions(+)
>
> diff --git a/hw/arm/bcm2838_peripherals.c b/hw/arm/bcm2838_peripherals.c
> index e7a9db97ab..60ed535673 100644
> --- a/hw/arm/bcm2838_peripherals.c
> +++ b/hw/arm/bcm2838_peripherals.c
> @@ -17,6 +17,9 @@
>  #define PCIE_MMIO_ARM_OFFSET    0x600000000
>  #define PCIE_MMIO_SIZE          0x40000000
>
> +#define CLOCK_ISP_OFFSET        0xc11000
> +#define CLOCK_ISP_SIZE          0x100
> +
>  /* Lower peripheral base address on the VC (GPU) system bus */
>  #define BCM2838_VC_PERI_LOW_BASE 0x7c000000
>
> @@ -224,6 +227,9 @@ static void bcm2838_peripherals_realize(DeviceState *dev, 
> Error **errp)
>      memory_region_add_subregion(get_system_memory(), PCIE_MMIO_ARM_OFFSET,
>                                  &s->pcie_mmio_alias);
>
> +    create_unimp(s_base, &s->clkisp, "bcm2835-clkisp", CLOCK_ISP_OFFSET,
> +                 CLOCK_ISP_SIZE);
> +
>      /* GPIO */
>      if (!sysbus_realize(SYS_BUS_DEVICE(&s->gpio), errp)) {
>          return;


Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM