Re: [PATCH 05/44] Add GIC-400 to BCM2838 SoC

[Peter Maydell]

On Wed, 26 Jul 2023 at 15:37, Sergey Kambalin <serg.oker@gmail.com> wrote:
>
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> ---
>  hw/arm/bcm2838.c                     | 167 +++++++++++++++++++++++++++
>  hw/arm/trace-events                  |   2 +
>  include/hw/arm/bcm2838.h             |   2 +
>  include/hw/arm/bcm2838_peripherals.h |  39 +++++++
>  4 files changed, 210 insertions(+)
>
> diff --git a/hw/arm/bcm2838.c b/hw/arm/bcm2838.c
> index dd650c8148..c687f38a39 100644
> --- a/hw/arm/bcm2838.c
> +++ b/hw/arm/bcm2838.c
> @@ -22,8 +22,36 @@ struct BCM2838Class {
>      hwaddr gic_base; /* GIC base address inside ARM local peripherals region 
> */
>  };
>
> +#define GIC400_MAINTAINANCE_IRQ      9

"MAINTENANCE"

> diff --git a/include/hw/arm/bcm2838_peripherals.h 
> b/include/hw/arm/bcm2838_peripherals.h
> index 8214003baf..0aed6f1bec 100644
> --- a/include/hw/arm/bcm2838_peripherals.h
> +++ b/include/hw/arm/bcm2838_peripherals.h
> @@ -11,6 +11,41 @@
>
>  #include "hw/arm/bcm2835_peripherals.h"
>
> +#define GENET_OFFSET            0x1580000

I'm guessing this #define ought to be in a later patch.

Otherwise:
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM