Re: [PATCH 1/3] Rework i.MX6UL device implementation/instantiation

[Peter Maydell]

On Wed, 26 Jul 2023 at 16:55, Jean-Christophe Dubois
<jcd@tribudubois.net> wrote:
>
> From: jcdubois <jcd@tribudubois.net>
>
> * Add Addr and size definition for all i.MX6UL devices in i.MX6UL header file.
> * Use those newly defined named constants whenever possible.
> * Standardize the way we init a familly of unimplemented devices
>   - SAI
>   - PWM (add missing PWM instances)
>   - CAN
> * Add TZASC as unimplemented device.
>   - Allow bare metal application to access this (unimplemented) device
> * Add CSU as unimplemented device.
>   - Allow bare metal application to access this (unimplemented) device
> * Change CAAM specific memory from ROM to RAM.
> * Add/rework few comments

This generally looks OK, but please can you split
out "refactoring, no behaviour change" changes into
separate patches from "change the behaviour" changes ?
The refactoring bits can all stay in one patch, but these
changes:

> * Add TZASC as unimplemented device.
>   - Allow bare metal application to access this (unimplemented) device
> * Add CSU as unimplemented device.
>   - Allow bare metal application to access this (unimplemented) device
> * Change CAAM specific memory from ROM to RAM.

should not be in the same patch with them.

It would also be handy for the commit message for the CAAM
patch to say why we want to change it to RAM.

thanks
-- PMM