[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/6] python/machine: remove unused sock_dir argument
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 6/6] python/machine: remove unused sock_dir argument |
Date: |
Tue, 25 Jul 2023 19:26:51 +0100 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Tue, Jul 25, 2023 at 02:03:37PM -0400, John Snow wrote:
> By using a socketpair for all of the sockets managed by the VM class and
> its extensions, we don't need the sock_dir argument anymore, so remove
> it.
>
> We only added this argument so that we could specify a second, shorter
> temporary directory for cases where the temp/log dirs were "too long" as
> a socket name on macOS. We don't need it for this class now. In one
> case, avocado testing takes over responsibility for creating an
> appropriate sockdir.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine/machine.py | 18 ------------------
> python/qemu/machine/qtest.py | 5 +----
> tests/avocado/acpi-bits.py | 5 +----
> tests/avocado/avocado_qemu/__init__.py | 2 +-
> tests/avocado/machine_aspeed.py | 5 ++++-
> tests/qemu-iotests/iotests.py | 2 +-
> tests/qemu-iotests/tests/copy-before-write | 3 +--
> 7 files changed, 9 insertions(+), 31 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 4/6] python/machine: use socketpair() for console connections, (continued)
[PATCH v2 5/6] python/machine: use socketpair() for qtest connection, John Snow, 2023/07/25
[PATCH v2 6/6] python/machine: remove unused sock_dir argument, John Snow, 2023/07/25
- Re: [PATCH v2 6/6] python/machine: remove unused sock_dir argument,
Daniel P . Berrangé <=
Re: [PATCH v2 0/6] python/machine: use socketpair() for console socket, Peter Maydell, 2023/07/27