Re: [PATCH v3 1/2] kvm: Introduce kvm_arch_get_default_type hook

[Philippe Mathieu-Daudé]

On 22/7/23 08:22, Akihiko Odaki wrote:
> kvm_arch_get_default_type() returns the default KVM type. This hook is
> particularly useful to derive a KVM type that is valid for "none"
> machine model, which is used by libvirt to probe the availability of
> KVM.
>
> For MIPS, the existing mips_kvm_type() is reused. This function ensures
> the availability of VZ which is mandatory to use KVM on the current
> QEMU.

Pre-existing: mips_kvm_type() returns -1. Should we check for
'type' in kvm_init() before calling kvm_ioctl()?

> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   include/sysemu/kvm.h     | 2 ++
>   target/mips/kvm_mips.h   | 9 ---------
>   accel/kvm/kvm-all.c      | 4 +++-
>   hw/mips/loongson3_virt.c | 1 -
>   target/arm/kvm.c         | 5 +++++
>   target/i386/kvm/kvm.c    | 5 +++++
>   target/mips/kvm.c        | 2 +-
>   target/ppc/kvm.c         | 5 +++++
>   target/riscv/kvm.c       | 5 +++++
>   target/s390x/kvm/kvm.c   | 5 +++++
>   10 files changed, 31 insertions(+), 12 deletions(-)