Re: [PATCH 1/1] hw/arm/sbsa-ref: set 'slots' property of xhci

[Philippe Mathieu-Daudé]

On 10/7/23 09:33, Marcin Juszkiewicz wrote:
> W dniu 10.07.2023 o 09:28, Richard Henderson pisze:
> > hw/usb/hcd-xhci-nec.c:    DEFINE_PROP_UINT32("slots", XHCINecState, 
> > slots, XHCI_MAXSLOTS),
> > hw/usb/hcd-xhci-sysbus.c:    DEFINE_PROP_UINT32("slots", 
> > XHCISysbusState, xhci.numslots, XHCI_MAXSLOTS),
> >
> > The default is XCHI_MAXSLOTS, not 1.  So I can't see why you'd need this.
>
> There are two systems using XHCI: i386/microvm and arm/sbsa. First
> one sets amount of slots already.
>
> Without this patch Linux complains that there is only one port and
> refuses to connect second usb device:
>
> xhci-hcd PNP0D10:00: Error while assigning device slot ID: No Slots 
> Available Error
> xhci-hcd PNP0D10:00: Max number of devices this xHCI host supports is 1.
> usb usb1-port2: couldn't allocate usb_device
>
> So it looks like default being XHCI_MAXSLOTS is not applied somewhere.

Or something sets it to 1 elsewhere.

At a glance xhci_sysbus_class_init() doesn't call
device_class_set_parent_FOO().