|
From: | Cédric Le Goater |
Subject: | Re: [PATCH v2 4/5] hw/arm/aspeed: Add aspeed_eeprom.c |
Date: | Tue, 17 Jan 2023 10:20:21 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 |
+#ifndef ASPEED_EEPROM_H +#define ASPEED_EEPROM_H + +#include "qemu/osdep.h" + +extern const uint8_t fby35_bmc_fruid[];may be define the array with an explicit size to avoid the size variable ? I don't see any good solution./* Return rom_size and set rombufptr, or return 0 */ size_t aspeed_get_default_rom_content(const char *machine_typename, const void **rombufptr);
Yes. I was thinking that such an helper would be useful longterm. I would add the I2C bus and address also, so internally we would maintain a sort-of-DB of roms for a machine type. Thanks, C.
[Prev in Thread] | Current Thread | [Next in Thread] |