[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for
From: |
Peter Maydell |
Subject: |
Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only |
Date: |
Tue, 10 Jan 2023 14:02:18 +0000 |
On Tue, 10 Jan 2023 at 13:36, Fabiano Rosas <farosas@suse.de> wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
> > On Tue, 10 Jan 2023 at 13:00, Fabiano Rosas <farosas@suse.de> wrote:
> >>
> >> Thomas Huth <thuth@redhat.com> writes:
> >>
> >> > On 09/01/2023 23.42, Fabiano Rosas wrote:
> >> >> From: Claudio Fontana <cfontana@suse.de>
> >> >>
> >> >> on ARM we currently list and build all machines, even when
> >> >> building KVM-only, without TCG.
> >> >>
> >> >> Until we fix this (and we only list and build machines that are
> >> >> compatible with KVM), only test specifically using the "virt"
> >> >> machine in this case.
> >> >
> >> > Why don't you fix it immediately? ...
> >>
> >> My idea was to have in this series the minimum to unbreak the
> >> --disable-tcg build and later bring the rest of the changes
> >> incrementally.
> >
> > This test is basically checking "all the machines should
> > work". That's an important invariant to maintain, so
> > I don't think we should just skip it for Arm targets.
>
> But what does "all machines" mean in a no-TCG build? The original intent
> of the patch was that only 'virt' should be present and therefore the
> only one tested.
It means "every machine the user can create". If the
machine can't run then either we shouldn't compile it
in, or else we should be compiling in enough extra stuff
to allow it to work.
-- PMM
- [RFC PATCH v2 09/19] target/arm: move helpers to tcg/, (continued)
- [RFC PATCH v2 09/19] target/arm: move helpers to tcg/, Fabiano Rosas, 2023/01/09
- [RFC PATCH v2 10/19] target/arm: Move psci.c into the tcg directory, Fabiano Rosas, 2023/01/09
- [RFC PATCH v2 11/19] target/arm: Wrap arm_rebuild_hflags calls with tcg_enabled, Fabiano Rosas, 2023/01/09
- [RFC PATCH v2 12/19] target/arm: Move hflags code into the tcg directory, Fabiano Rosas, 2023/01/09
- [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/09
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Thomas Huth, 2023/01/10
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/10
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Peter Maydell, 2023/01/10
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/10
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only,
Peter Maydell <=
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Claudio Fontana, 2023/01/11
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Thomas Huth, 2023/01/11
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/11
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Richard Henderson, 2023/01/11
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/12
- Re: [RFC PATCH v2 13/19] tests: do not run test-hmp on all machines for ARM KVM-only, Peter Maydell, 2023/01/12
[RFC PATCH v2 14/19] tests: do not run qom-test on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/09
[RFC PATCH v2 15/19] tests: device-introspect-test: cope with ARM TCG-only devices, Fabiano Rosas, 2023/01/09
[RFC PATCH v2 16/19] tests/tcg: Do not build/run TCG tests if TCG is disabled, Fabiano Rosas, 2023/01/09
[RFC PATCH v2 17/19] target/arm: Move regime_using_lpae_format into internal.h, Fabiano Rosas, 2023/01/09