[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH qemu.git 02/11] hw/timer/imx_epit: improve comments
From: |
~axelheider |
Subject: |
[PATCH qemu.git 02/11] hw/timer/imx_epit: improve comments |
Date: |
Tue, 25 Oct 2022 17:33:43 +0200 |
From: Axel Heider <axel.heider@hensoldt.net>
Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
---
hw/timer/imx_epit.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index 06785fe6f6..b6c013292f 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -352,8 +352,18 @@ static void imx_epit_realize(DeviceState *dev, Error
**errp)
0x00001000);
sysbus_init_mmio(sbd, &s->iomem);
+ /*
+ * The reload timer keeps running when the peripheral is enabled. It is a
+ * kind of wall clock that does not generate any interrupts. The callback
+ * needs to be provided, but it does nothing as the ptimer already supports
+ * all necessary reloading functionality.
+ */
s->timer_reload = ptimer_init(imx_epit_reload, s, PTIMER_POLICY_LEGACY);
+ /*
+ * The compare timer is running only when the peripheral configuration is
+ * in a state that will generate compare interrupts.
+ */
s->timer_cmp = ptimer_init(imx_epit_cmp, s, PTIMER_POLICY_LEGACY);
}
--
2.34.5
- [PATCH qemu.git 00/11] improve hw/timer/imx_epit, ~axelheider, 2022/10/30
- [PATCH qemu.git 02/11] hw/timer/imx_epit: improve comments,
~axelheider <=
- [PATCH qemu.git 04/11] hw/timer/imx_epit: remove explicit fields cnt and freq, ~axelheider, 2022/10/30
- [PATCH qemu.git 03/11] hw/timer/imx_epit: factor out register write handlers, ~axelheider, 2022/10/30
- [PATCH qemu.git 06/11] hw/timer/imx_epit: software reset clears the interrupt, ~axelheider, 2022/10/30
- [PATCH qemu.git 09/11] hw/timer/imx_epit: cleanup CR defines, ~axelheider, 2022/10/30
- [PATCH qemu.git 01/11] hw/timer/imx_epit: fix typo in comment, ~axelheider, 2022/10/30
- [PATCH qemu.git 05/11] hw/timer/imx_epit: simplify interrupt logic, ~axelheider, 2022/10/30