qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 09/14] target/arm: Don't shift attrs in get_phys_addr_lpae


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 09/14] target/arm: Don't shift attrs in get_phys_addr_lpae
Date: Fri, 21 Oct 2022 11:27:42 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.2

On 21/10/22 00:35, Richard Henderson wrote:
Leave the upper and lower attributes in the place they originate
from in the descriptor.  Shifting them around is confusing, since
one cannot read the bit numbers out of the manual.  Also, new
attributes have been added which would alter the shifts.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/arm/ptw.c | 31 +++++++++++++++----------------
  1 file changed, 15 insertions(+), 16 deletions(-)

      if (regime_is_stage2(mmu_idx)) {
          ns = mmu_idx == ARMMMUIdx_Stage2;
-        xn = extract32(attrs, 11, 2);
+        xn = extract64(attrs, 54, 2);

54 -> 53?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]