[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 33/42] target/arm: Split out S1TranslateResult type
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 33/42] target/arm: Split out S1TranslateResult type |
Date: |
Fri, 7 Oct 2022 10:27:52 +0100 |
On Sat, 1 Oct 2022 at 17:56, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Consolidate the results of S1_ptw_translate in one struct.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/ptw.c | 70 +++++++++++++++++++++++++-----------------------
> 1 file changed, 36 insertions(+), 34 deletions(-)
>
> diff --git a/target/arm/ptw.c b/target/arm/ptw.c
> index 7a77bea2c7..99ad894180 100644
> --- a/target/arm/ptw.c
> +++ b/target/arm/ptw.c
> @@ -220,13 +220,18 @@ static bool S2_attrs_are_device(uint64_t hcr, uint8_t
> attrs)
> }
> }
>
> +typedef struct {
> + bool is_secure;
> + void *hphys;
> + hwaddr gphys;
> +} S1TranslateResult;
Ah, I was wondering whether to suggest this for the previous patch
that added the hphys and gphys arguments :-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH v3 29/42] target/arm: Use bool consistently for get_phys_addr subroutines, (continued)
[PATCH v3 33/42] target/arm: Split out S1TranslateResult type, Richard Henderson, 2022/10/01
- Re: [PATCH v3 33/42] target/arm: Split out S1TranslateResult type,
Peter Maydell <=
[PATCH v3 34/42] target/arm: Move be test for regime into S1TranslateResult, Richard Henderson, 2022/10/01
[PATCH v3 35/42] target/arm: Move S1_ptw_translate outside arm_ld[lq]_ptw, Richard Henderson, 2022/10/01
[PATCH v3 30/42] target/arm: Add ptw_idx argument to S1_ptw_translate, Richard Henderson, 2022/10/01
[PATCH v3 36/42] target/arm: Add ARMFault_UnsuppAtomicUpdate, Richard Henderson, 2022/10/01
[PATCH v3 37/42] target/arm: Remove loop from get_phys_addr_lpae, Richard Henderson, 2022/10/01