Re: [PATCH v1 5/6] hw/misc: Add a model of the Xilinx ZynqMP APU Control

[Philippe Mathieu-Daudé]

On 31/1/22 13:17, Edgar E. Iglesias wrote:
> On Mon, Jan 31, 2022 at 12:35:54AM +0100, Philippe Mathieu-Daudé wrote:
> > On 31/1/22 00:12, Edgar E. Iglesias wrote:
> > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
> > >
> > > Add a model of the Xilinx ZynqMP APU Control.
> > >
> > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> > > ---
> > >    include/hw/misc/xlnx-zynqmp-apu-ctrl.h |  91 +++++++++
> > >    hw/misc/xlnx-zynqmp-apu-ctrl.c         | 257 +++++++++++++++++++++++++
> > >    hw/misc/meson.build                    |   1 +
> > >    3 files changed, 349 insertions(+)
> > >    create mode 100644 include/hw/misc/xlnx-zynqmp-apu-ctrl.h
> > >    create mode 100644 hw/misc/xlnx-zynqmp-apu-ctrl.c

> > > +
> > > +#define NUM_CPUS 4
> >
> > Hmm isn't it APU_MAX_CPU?
>
>
> Thanks Philippe. Yes, this was a little confusing. The values happen to be the
> same but they belong to different models. For example, the apu-ctrl model will 
> be
> reused in Versal.
>
> Anyways, for v2 I've renamed the macros to CRF_MAX_CPU and APU_MAX_CPU 
> respectevly.
> I hope that makes things clearer.

Thanks!